Add HashWriter without ser-type and ser-version and use it where possible
ClosedPublic
Actions

Authored by Fabien on Jul 15 2024, 21:16.

Details

Reviewers

roqqit
PiRK

Group Reviewers

Restricted Project

Commits

rABC78cbb32b9c3d: Add HashWriter without ser-type and ser-version and use it where possible

Summary

The basic idea is that serialization type should not be initialized when it is not needed. Same for the serialization version.
So do this here for HashWriter. CHashWriter remains in places where it is not yet possible.

Backport of core#25331 and core#28341.

Test Plan

ninja all check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR25331

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29571
Build 58677: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-clang-tidy · build-debug
Build 58676: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 15 2024, 21:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2024, 21:16

Fabien requested review of this revision.Jul 15 2024, 21:16

teamcity edited the summary of this revision. (Show Details)Jul 15 2024, 21:16

Harbormaster completed remote builds in B29566: Diff 48638.Jul 15 2024, 21:38

roqqit requested changes to this revision.Jul 15 2024, 22:46

roqqit added a subscriber: roqqit.

roqqit added inline comments.

src/avalanche/processor.cpp
494 ↗	(On Diff #48638)	Please cleanup these empty-line semicolons throughout the diff. Changes look good otherwise.

This revision now requires changes to proceed.Jul 15 2024, 22:46

Fabien added inline comments.Jul 16 2024, 07:49

src/avalanche/processor.cpp
494 ↗	(On Diff #48638)	Ah, I knew I created these double semicolons during copy pasting, but wanted to see if the linter will catch it, which it did... But I missed that it added it back on a newline :(