Page MenuHomePhabricator

net: use an interface class rather than signals for message processing
ClosedPublic

Authored by deadalnix on Sep 10 2018, 12:33.

Details

Summary

Drop boost signals in favor of a stateful class. This will allow the message
processing loop to actually move to net_processing in a future step.

This is part of core PR10756

Depends on D1744 and D1748

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr10756
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3259
Build 4605: Bitcoin ABC Buildbot (legacy)
Build 4604: arc lint + arc unit

Event Timeline

Finalize the backport as next commits are trivial

schancel added a subscriber: schancel.

Was there ever a reason for multiple signal handlers to be registered at the same time? I suppose that could still be done with a wrapper...

This revision is now accepted and ready to land.Sep 10 2018, 20:41