Page MenuHomePhabricator
Differential D1765

boost: drop boost threads for upnp
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2018, 17:10.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING4f4f465c74e6: boost: drop boost threads for upnp
rABC4f4f465c74e6: boost: drop boost threads for upnp
Summary

This is part of core PR12381

Test Plan
make

There do not seem to be any test for upnp.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
upnpthread
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3310
Build 4704: Bitcoin ABC Buildbot (legacy)
Build 4703: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2018, 17:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2018, 17:10
teamcity added a subscriber: teamcity.Sep 11 2018, 17:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 11 2018, 17:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3267: Diff 4877!Sep 11 2018, 17:14
schancel accepted this revision.Sep 15 2018, 15:00
This revision is now accepted and ready to land.Sep 15 2018, 15:00
deadalnix updated this revision to Diff 4927.Sep 15 2018, 17:37

rebase

teamcity added a comment.Sep 15 2018, 18:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 15 2018, 18:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3304: Diff 4927!Sep 15 2018, 18:28
deadalnix updated this revision to Diff 4935.Sep 15 2018, 18:47

Use ; as an empty statement instead of {}

teamcity added a comment.Sep 15 2018, 19:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3310: Diff 4935.Sep 15 2018, 19:43
teamcity added a comment.Sep 15 2018, 19:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC4f4f465c74e6: boost: drop boost threads for upnp (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain WhySep 15 2018, 20:03
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2229: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Dec 28 2018, 15:52
Fabien mentioned this in rABC6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Dec 31 2018, 13:18
Fabien mentioned this in rSTAGING6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Jan 20 2019, 23:54

Revision Contents
Changeset List

PathSize
src/
7 lines
4 lines
94 lines
qt/
7 lines

Diff 4935

View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/qt/optionsmodel.cpp

Loading...