Differential D1789

Address nits from per-utxo change
ClosedPublic
Actions

Authored by deadalnix on Sep 17 2018, 21:08.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING6101540edd98: Address nits from per-utxo change
rABC6101540edd98: Address nits from per-utxo change

Summary

Add belt-and-suspenders in DisconnectBlock

These extra variables were previously checked before the move to per-txout database.

Comment clarifications in coins.cpp

This is a backport of core PR10558

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

utxodbnit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3318
Build 4719: Bitcoin ABC Buildbot (legacy)
Build 4718: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 17 2018, 21:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2018, 21:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel accepted this revision.Sep 17 2018, 21:20

This revision is now accepted and ready to land.Sep 17 2018, 21:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3318: Diff 4952.Sep 17 2018, 21:46

Closed by commit rABC6101540edd98: Address nits from per-utxo change (authored by Alex Morcos <morcos@chaincode.com>, committed by deadalnix). · Explain WhySep 17 2018, 22:23

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

coins.h

3 lines

validation.cpp

5 lines

Diff 4952

View Options

src/coins.h