[qa] rearrange assertion in wallet-accounts
ClosedPublic
Actions

Authored by schancel on Sep 23 2018, 02:35.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGab707c825e9a: [qa] rearrange assertion in wallet-accounts
rABCab707c825e9a: [qa] rearrange assertion in wallet-accounts

Summary

Previously, this test sent the mined fee in order to remove it from
the default account. However, if this fee is less than the dust_limit
then sendfrom will fail. This commit rearranges the assertions so
that sending an amount below the dust threshold is unnecessary.

Test Plan

./test/functional/test_runner.py wallet-accounts

Diff Detail

Repository

rABC Bitcoin ABC

Branch

wallet-accounts-test

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3343
Build 4769: Bitcoin ABC Buildbot (legacy)
Build 4768: arc lint + arc unit

Event Timeline

schancel created this revision.Sep 23 2018, 02:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2018, 02:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3343: Diff 4995.Sep 23 2018, 02:54

lol. should have been this way from the beginning.

This revision is now accepted and ready to land.Sep 23 2018, 16:46

Closed by commit rABCab707c825e9a: [qa] rearrange assertion in wallet-accounts (authored by schancel). · Explain WhySep 23 2018, 21:11

This revision was automatically updated to reflect the committed changes.

jasonbcox mentioned this in D4528: Merge #13498: [wallet] Fixups from account API deprecation.Nov 23 2019, 17:42

nakihito mentioned this in D5316: Merge #14023: Remove accounts rpcs.Mar 4 2020, 20:04

Revision Contents
Changeset List

Path

Size

test/

functional/

wallet-accounts.py

12 lines

Diff 4995

View Options

test/functional/wallet-accounts.py

[qa] rearrange assertion in wallet-accountsClosedPublicActions