Paths

Table of Contentst

Differential D17557

[Cashtab] Convert wallet management screen to typescript
ClosedPublic
Actions

Authored by bytesofman on Sat, Jan 18, 00:25.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2615794e3596: [Cashtab] Convert wallet management screen to typescript

Summary

Convert to typescript as prep for improving how wallets are activated similar to dropdown wallet select improvements

In implementing typescript, patch type-related bug

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Sat, Jan 18, 00:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jan 18, 00:25

bytesofman added inline comments.Sat, Jan 18, 00:28

cashtab/src/components/Wallets/index.tsx
277 ↗	(On Diff #52292)	typescript can find this kind of bug immediately we were comparing wallet.name against wallet, instead of wallet.name against newImportedWallet.name it's a crazy edge case to import a wallet that happens to have the same first 5 characters of an address as the other wallet, hence untested ... but still nice to catch

Harbormaster completed remote builds in B32152: Diff 52292.Sat, Jan 18, 00:30

bytesofman added a child revision: D17558: [Cashtab] Improve wallet select behavior on wallets screen.Sat, Jan 18, 00:34

bytesofman published this revision for review.Sat, Jan 18, 00:36

emack accepted this revision.Sat, Jan 18, 04:22

This revision is now accepted and ready to land.Sat, Jan 18, 04:22

Closed by commit rABC2615794e3596: [Cashtab] Convert wallet management screen to typescript (authored by bytesofman). · Explain WhySat, Jan 18, 09:07

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC2615794e3596: [Cashtab] Convert wallet management screen to typescript.

Revision Contents
Changeset List

Path

Size

cashtab/

package-lock.json

4 lines

2 lines

src/

components/

Wallets/

	index.tsx
	index.js

95 lines

	styles.ts
	styles.js

Diff 52298

cashtab/package-lock.json

Loading...

cashtab/package.json

Loading...

cashtab/src/components/Wallets/index.js

Loading...

cashtab/src/components/Wallets/index.tsx

Loading...

cashtab/src/components/Wallets/styles.js

Loading...

cashtab/src/components/Wallets/styles.ts

Loading...