Page MenuHomePhabricator
Differential D17760

[electrum] implement eMPP parsing
Needs ReviewPublic
Actions

Authored by PiRK on Thu, Mar 6, 16:41.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Depends on D17558

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32609
Build 64706: Build Diffelectrum-tests
Build 64705: arc lint + arc unit

Event Timeline

PiRK created this revision.Thu, Mar 6, 16:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 6, 16:41
PiRK requested review of this revision.Thu, Mar 6, 16:41
Harbormaster completed remote builds in B32608: Diff 52949.Thu, Mar 6, 16:44
PiRK updated this revision to Diff 52950.Thu, Mar 6, 17:28

add tests for incorrect data length in otherwise valid succession of push ops

Harbormaster completed remote builds in B32609: Diff 52950.Thu, Mar 6, 17:31
PiRK added inline comments.Thu, Mar 6, 17:32
electrum/electrumabc/transaction.py
788

OpCodes is an IntEnum, so in theory it is already an alias for int. But various code quality tools will not be happy if we pass an int instead of one of the enum values without this change, and some push opcodes (17 to 0x4e) are not explicitly listed.

PiRK added inline comments.Thu, Mar 6, 17:34
electrum/electrumabc/transaction.py
788

correction: 0x01 to 0x4B (push n bytes, with 1 <= n <= 0x4B)

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
tests/
55 lines
tokens/
84 lines
2 lines

Diff 52950

View Options

electrum/electrumabc/tests/test_empp.py

Loading...
View Options

electrum/electrumabc/tokens/empp.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...