Page MenuHomePhabricator
Differential D17760

[electrum] implement eMPP parsing
ClosedPublic
Actions

Authored by PiRK on Thu, Mar 6, 16:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3e0722f77bc2: [electrum] implement eMPP parsing
Summary

Depends on D17558

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Thu, Mar 6, 16:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 6, 16:41
PiRK requested review of this revision.Thu, Mar 6, 16:41
Harbormaster completed remote builds in B32608: Diff 52949.Thu, Mar 6, 16:44
PiRK updated this revision to Diff 52950.Thu, Mar 6, 17:28

add tests for incorrect data length in otherwise valid succession of push ops

Harbormaster completed remote builds in B32609: Diff 52950.Thu, Mar 6, 17:31
PiRK added inline comments.Thu, Mar 6, 17:32
electrum/electrumabc/transaction.py
788 ↗(On Diff #52950)

OpCodes is an IntEnum, so in theory it is already an alias for int. But various code quality tools will not be happy if we pass an int instead of one of the enum values without this change, and some push opcodes (17 to 0x4e) are not explicitly listed.

PiRK added inline comments.Thu, Mar 6, 17:34
electrum/electrumabc/transaction.py
788 ↗(On Diff #52950)

correction: 0x01 to 0x4B (push n bytes, with 1 <= n <= 0x4B)

Fabien requested changes to this revision.Fri, Mar 7, 10:19
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/tokens/empp.py
52 ↗(On Diff #52950)

min_data_size of 2 is excluding 0x01 which is fine (single byte push)

This revision now requires changes to proceed.Fri, Mar 7, 10:19
PiRK updated this revision to Diff 52963.Fri, Mar 7, 13:08

support opcode 0x01, write more tests, find out that the op == OpCodes.OP_PUSHDATA4 branch is wrong, fix it

PiRK added inline comments.Fri, Mar 7, 13:09
electrum/electrumabc/tests/test_empp.py
19 ↗(On Diff #52963)

this is minimally encoded as OP_2

Harbormaster completed remote builds in B32619: Diff 52963.Fri, Mar 7, 13:10
PiRK updated this revision to Diff 52964.Fri, Mar 7, 13:10

remove a print

Harbormaster completed remote builds in B32620: Diff 52964.Fri, Mar 7, 13:13
Fabien accepted this revision.Fri, Mar 7, 15:26
This revision is now accepted and ready to land.Fri, Mar 7, 15:26
Closed by commit rABC3e0722f77bc2: [electrum] implement eMPP parsing (authored by PiRK). · Explain WhyFri, Mar 7, 15:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3e0722f77bc2: [electrum] implement eMPP parsing.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
tests/
80 lines
tokens/
84 lines
2 lines

Diff 52970

View Options

electrum/electrumabc/tests/test_empp.py

Loading...
View Options

electrum/electrumabc/tokens/empp.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...