Page MenuHomePhabricator
Differential D1873

net: Improve and document SOCKS code
ClosedPublic
Actions

Authored by deadalnix on Oct 3 2018, 15:36.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3a2be3a1fe29: net: Improve and document SOCKS code
rABC3a2be3a1fe29: net: Improve and document SOCKS code
Summary

Make the SOCKS code more consistent, and document the constants used.

This is a backport of Core PR11397

Depends on D1872

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
improvesocks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3506
Build 5088: Bitcoin ABC Buildbot (legacy)
Build 5087: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 3 2018, 15:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2018, 15:36
teamcity added a subscriber: teamcity.Oct 3 2018, 15:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1874: net: Split socket create/connect.Oct 3 2018, 15:51
teamcity added a comment.Oct 3 2018, 15:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3496: Diff 5250.Oct 3 2018, 15:55
jasonbcox added a subscriber: jasonbcox.Oct 3 2018, 20:07
jasonbcox added inline comments.
src/netbase.cpp
241 ↗(On Diff #5250)

char* -> uint8_t* seems like it provides no value if it's just going to be cast inside the function. Is this just to be consistent, external to the implementation details, with other migrations to uintX_t types?

deadalnix marked an inline comment as done.Oct 4 2018, 09:34
deadalnix added inline comments.
src/netbase.cpp
241 ↗(On Diff #5250)

The signedness of char is implementation defined (signed on X86, unsigned on ARM). I don't think we want to deal with that more than strictly required.

deadalnix updated this revision to Diff 5265.Oct 4 2018, 10:12

rebase

teamcity added a comment.Oct 4 2018, 10:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 4 2018, 10:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3506: Diff 5265.Oct 4 2018, 10:29
jasonbcox accepted this revision.Oct 5 2018, 05:31
This revision is now accepted and ready to land.Oct 5 2018, 05:31
Closed by commit rABC3a2be3a1fe29: net: Improve and document SOCKS code (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by deadalnix). · Explain WhyOct 5 2018, 09:24
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
116 lines

Diff 5265

View Options

src/netbase.cpp

Loading...