Page MenuHomePhabricator
Differential D1928

init: Factor out AppInitLockDataDirectory
ClosedPublic
Actions

Authored by jasonbcox on Oct 12 2018, 22:01.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING9787445e478a: init: Factor out AppInitLockDataDirectory
rABC9787445e478a: init: Factor out AppInitLockDataDirectory
Summary

Alternative to #10818, alternative solution to #10815.

After this change: All the AppInit steps before and inclusive
AppInitLockDataDirectory must not have Shutdown() called in case of
failure. Only when AppInitMain fails, Shutdown should be called.

Changes the GUI and bitcoind code to consistently do this.

Backport of Core PR 10832.
Completes T426

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

ninja && test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10832
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3604
Build 5283: Bitcoin ABC Buildbot (legacy)
Build 5282: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 12 2018, 22:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2018, 22:02
teamcity added a subscriber: teamcity.Oct 12 2018, 22:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 12 2018, 22:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3597: Diff 5406!Oct 12 2018, 22:07
deadalnix requested changes to this revision.Oct 14 2018, 19:03
deadalnix added inline comments.
src/qt/bitcoin.cpp
783 ↗(On Diff #5406)

Remove. We don't support older version of Qt.

790 ↗(On Diff #5406)

Revert

This revision now requires changes to proceed.Oct 14 2018, 19:03
jasonbcox updated this revision to Diff 5422.Oct 15 2018, 21:45

Fixed according to feedback

teamcity added a comment.Oct 15 2018, 21:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 15 2018, 21:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3604: Diff 5422!Oct 15 2018, 21:51
jasonbcox updated this revision to Diff 5423.Oct 15 2018, 22:42

Fixed build. Apparently cmake wasn't building the qt directory properly. I'll continue to investigate...

teamcity added a comment.Oct 15 2018, 22:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 15 2018, 22:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3605: Diff 5423.Oct 15 2018, 22:52
deadalnix accepted this revision.Oct 16 2018, 07:56
This revision is now accepted and ready to land.Oct 16 2018, 07:56
Closed by commit rABC9787445e478a: init: Factor out AppInitLockDataDirectory (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyOct 16 2018, 17:31
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D3011: Merge #9833: Trivial: fix comments referencing AppInit2.May 10 2019, 03:13
Diffusion mentioned this in rABC6c97506519c9: Merge #9833: Trivial: fix comments referencing AppInit2.May 14 2019, 17:16
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING6c97506519c9: Merge #9833: Trivial: fix comments referencing AppInit2.Sep 18 2019, 23:31

Revision Contents
Changeset List

PathSize
src/
5 lines
21 lines
17 lines
qt/
67 lines

Diff 5422

View Options

src/bitcoind.cpp

Loading...
View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...