Differential D1942

Track the best parked chain tip.
ClosedPublic
Actions

Authored by deadalnix on Oct 20 2018, 12:07.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGce0a84c66a91: Track the best parked chain tip.
rABCce0a84c66a91: Track the best parked chain tip.

Summary

This ensures we keep track of the best parked chain, so we can reconsider it when the time comes.

Depends on D1945

Test Plan

Unfortunately, I'm not sure how to test this.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

trackparkedchain

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3631
Build 5337: Bitcoin ABC Buildbot (legacy)
Build 5336: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 20 2018, 12:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2018, 12:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3625: Diff 5453.Oct 20 2018, 12:53

rebase on top of D1945

deadalnix edited the summary of this revision. (Show Details)Oct 20 2018, 15:45

deadalnix added a parent revision: D1945: Refactor FindMostWorkChain.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3631: Diff 5459.Oct 20 2018, 15:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1947: Properly track the "best" invalid tip.Oct 20 2018, 16:19

jasonbcox accepted this revision.Oct 20 2018, 16:33

This revision is now accepted and ready to land.Oct 20 2018, 16:33

Closed by commit rABCce0a84c66a91: Track the best parked chain tip. (authored by deadalnix). · Explain WhyOct 20 2018, 18:55

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

14 lines

Diff 5459

View Options

Track the best parked chain tip.ClosedPublicActions