Paths

Table of Contentst

Differential D2012

[rpc] Undeprecate estimatefee
ClosedPublic
Actions

Authored by schancel on Nov 6 2018, 17:42.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGa4c86bad8530: [rpc] Undeprecate estimatefee
rABCa4c86bad8530: [rpc] Undeprecate estimatefee

Summary

Revert "[rpc] Deprecate estimatefee RPC" (D1920)

This reverts PARTIALLY reverts commit 49ff27fedd365dcf5f7639fd2bda5dfc3cc58f51

The instrumentation for enabling deprecated RPCs is left in place for future use.
However, estimatefee should not be deprecated in a point release. It's also possible
that it should not be deprecated at all since we removed estimatesmartefee which
core deprecated this in favor of.

Depends on D2013

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

undep-estimatefeee (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3787
Build 5648: Bitcoin ABC Buildbot (legacy)
Build 5647: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 6 2018, 17:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2018, 17:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3787: Diff 5670.Nov 6 2018, 17:50

schancel edited the summary of this revision. (Show Details)Nov 6 2018, 17:51

schancel edited the summary of this revision. (Show Details)

1/ Why this should not be deprecated ?
2/ This remove any testing of the deprecated capabilities.

This revision now requires changes to proceed.Nov 6 2018, 17:54

Because people use it? It was deprecated in favor of estimatesmartfee which we already removed instead?

schancel edited the summary of this revision. (Show Details)Nov 6 2018, 18:16

schancel edited the summary of this revision. (Show Details)Nov 6 2018, 18:44

schancel added a parent revision: D2013: [rpc] Add a unittest for IsDeprecatedRPCEnabled.

Fix feedback by adding a unittest in this stack

Rebase to add missing server_tests.cpp file

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3789: Diff 5673!Nov 6 2018, 18:52

Harbormaster completed remote builds in B3791: Diff 5675.Nov 6 2018, 18:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

This should change the release notes.

Talked with Shae offline and we agree this is better to have in the next release. We'll deprecate it again later when the deprecation plan is a little more clear.

deadalnix accepted this revision.Nov 7 2018, 17:12

This revision is now accepted and ready to land.Nov 7 2018, 17:12

Closed by commit rABCa4c86bad8530: [rpc] Undeprecate estimatefee (authored by schancel). · Explain WhyNov 7 2018, 17:19

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in D2364: [tests] Rename feature_* functional tests..Jan 21 2019, 15:30

Fabien mentioned this in D2380: [tests] Rename rpc_* functional tests.Jan 22 2019, 10:46

Fabien mentioned this in rABC7922c7a81e81: [tests] Rename rpc_* functional tests.Jan 23 2019, 09:57

Fabien mentioned this in rSTAGING7922c7a81e81: [tests] Rename rpc_* functional tests.Sep 18 2019, 22:02