Differential D2064

Finish conversion of rpc to use pushKV
ClosedPublic
Actions

Authored by Fabien on Nov 13 2018, 19:19.

Tags

None

Subscribers

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING3d981bc03584: Finish conversion of rpc to use pushKV
rABC3d981bc03584: Finish conversion of rpc to use pushKV

Summary

As per title. Fixes missed changes from D1990.

Test Plan

make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-pushkv

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3896
Build 5864: Bitcoin ABC Buildbot (legacy)
Build 5863: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 13 2018, 19:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2018, 19:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3896: Diff 5812.Nov 13 2018, 19:30

src/wallet/db.cpp:355 make_pair => std::make_pair

src/qt/walletmodel.cpp
324	std::make_pair
src/rest.cpp
632	missed
src/rpc/blockchain.cpp
91	missed
111	dito
136	dito
1123	dito
src/rpc/mining.cpp
661	dito
663	dito
src/rpc/misc.cpp
116	dito
119	dito
132	dito
248	dito
272	dito
src/rpc/net.cpp
473	dito
496	dito
579	dito
586	dito
590	dito
592	dito
src/rpc/rawtransaction.cpp
70	dito
80	dito
87	dito
719	dito
src/wallet/rpcwallet.cpp
2997	dito
2999	dito
3289	dito
3296	dito

Address feedback on missed push_back(Pair('s

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3899: Diff 5815.Nov 13 2018, 20:32

Fabien requested changes to this revision.Nov 13 2018, 21:13

Fabien added inline comments.

src/rpc/mining.cpp
255 ↗	(On Diff #5815)	Missed
src/rpc/rawtransaction.cpp
117 ↗	(On Diff #5815)	missed
src/wallet/rpcwallet.cpp
1515 ↗	(On Diff #5815)	missed
1544 ↗	(On Diff #5815)	missed
3006 ↗	(On Diff #5815)	missed
3289 ↗	(On Diff #5815)	missed

This revision now requires changes to proceed.Nov 13 2018, 21:13

Fix remaining push_backs

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3901: Diff 5817!Nov 14 2018, 00:08

Fabien added inline comments.Nov 16 2018, 22:47

src/rpc/mining.cpp
636 ↗	(On Diff #5817)	this ; get transformed into :

Fabien requested changes to this revision.Nov 16 2018, 23:21

This revision now requires changes to proceed.Nov 16 2018, 23:21

Fix typo

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3937: Diff 5863!Nov 17 2018, 22:19

deadalnix accepted this revision.Nov 21 2018, 17:24

Rebase on master

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4029: Diff 5989.Nov 21 2018, 19:53

Fabien accepted this revision.Nov 21 2018, 20:12

This revision is now accepted and ready to land.Nov 21 2018, 20:12

schancel added a child revision: D2114: [rpc] add getfinalizedblockhash to return the current finalized block.Nov 21 2018, 20:19

Fabien commandeered this revision.Nov 22 2018, 15:21

Fabien edited reviewers, added: schancel; removed: Fabien.

Closed by commit rABC3d981bc03584: Finish conversion of rpc to use pushKV (authored by schancel, committed by Fabien). · Explain WhyNov 22 2018, 15:22

This revision was automatically updated to reflect the committed changes.

Fabien removed a child revision: D2114: [rpc] add getfinalizedblockhash to return the current finalized block.Nov 22 2018, 15:22

Revision Contents
Changeset List

Path

Size

src/

qt/

walletmodel.cpp

2 lines

6 lines

rpc/

30 lines

9 lines

6 lines

21 lines

rawtransaction.cpp

3 lines

wallet/

17 lines

Diff 5812

src/qt/walletmodel.cpp

Loading...

src/rest.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/misc.cpp

Loading...

src/rpc/net.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...