Page MenuHomePhabricator
Differential D2064

Finish conversion of rpc to use pushKV
ClosedPublic
Actions

Authored by Fabien on Nov 13 2018, 19:19.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING3d981bc03584: Finish conversion of rpc to use pushKV
rABC3d981bc03584: Finish conversion of rpc to use pushKV
Summary

As per title. Fixes missed changes from D1990.

Test Plan
make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-pushkv
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3899
Build 5870: Bitcoin ABC Buildbot (legacy)
Build 5869: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 13 2018, 19:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2018, 19:19
teamcity added a subscriber: teamcity.Nov 13 2018, 19:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 13 2018, 19:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3896: Diff 5812.Nov 13 2018, 19:30
Fabien added a subscriber: Fabien.Nov 13 2018, 20:01

src/wallet/db.cpp:355 make_pair => std::make_pair

src/qt/walletmodel.cpp
324 ↗(On Diff #5812)

std::make_pair

src/rest.cpp
632 ↗(On Diff #5812)

missed

src/rpc/blockchain.cpp
91 ↗(On Diff #5812)

missed

111 ↗(On Diff #5812)

dito

136 ↗(On Diff #5812)

dito

1123 ↗(On Diff #5812)

dito

src/rpc/mining.cpp
661 ↗(On Diff #5812)

dito

663 ↗(On Diff #5812)

dito

src/rpc/misc.cpp
116 ↗(On Diff #5812)

dito

119 ↗(On Diff #5812)

dito

132 ↗(On Diff #5812)

dito

248 ↗(On Diff #5812)

dito

272 ↗(On Diff #5812)

dito

src/rpc/net.cpp
473 ↗(On Diff #5812)

dito

496 ↗(On Diff #5812)

dito

579 ↗(On Diff #5812)

dito

586 ↗(On Diff #5812)

dito

590 ↗(On Diff #5812)

dito

592 ↗(On Diff #5812)

dito

src/rpc/rawtransaction.cpp
70 ↗(On Diff #5812)

dito

80 ↗(On Diff #5812)

dito

87 ↗(On Diff #5812)

dito

719 ↗(On Diff #5812)

dito

src/wallet/rpcwallet.cpp
2997 ↗(On Diff #5812)

dito

2999 ↗(On Diff #5812)

dito

3289 ↗(On Diff #5812)

dito

3296 ↗(On Diff #5812)

dito

schancel updated this revision to Diff 5815.Nov 13 2018, 20:24
schancel marked an inline comment as done.

Address feedback on missed push_back(Pair('s

teamcity added a comment.Nov 13 2018, 20:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 13 2018, 20:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3899: Diff 5815.Nov 13 2018, 20:32
Fabien requested changes to this revision.Nov 13 2018, 21:13
Fabien added inline comments.
src/rpc/mining.cpp
255

Missed

src/rpc/rawtransaction.cpp
117

missed

src/wallet/rpcwallet.cpp
1515

missed

1544

missed

3006

missed

3289

missed

This revision now requires changes to proceed.Nov 13 2018, 21:13
schancel updated this revision to Diff 5817.Nov 14 2018, 00:04
schancel marked an inline comment as done.

Fix remaining push_backs

teamcity added a comment.Nov 14 2018, 00:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 14 2018, 00:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3901: Diff 5817!Nov 14 2018, 00:08
Fabien added inline comments.Nov 16 2018, 22:47
src/rpc/mining.cpp
636 ↗(On Diff #5817)

this ; get transformed into :

Fabien requested changes to this revision.Nov 16 2018, 23:21
This revision now requires changes to proceed.Nov 16 2018, 23:21
schancel updated this revision to Diff 5863.Nov 17 2018, 22:12

Fix typo

teamcity added a comment.Nov 17 2018, 22:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 17 2018, 22:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3937: Diff 5863!Nov 17 2018, 22:19
deadalnix accepted this revision.Nov 21 2018, 17:24
schancel updated this revision to Diff 5989.Nov 21 2018, 19:43

Rebase on master

teamcity added a comment.Nov 21 2018, 19:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 21 2018, 19:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4029: Diff 5989.Nov 21 2018, 19:53
Fabien accepted this revision.Nov 21 2018, 20:12
This revision is now accepted and ready to land.Nov 21 2018, 20:12
schancel added a child revision: D2114: [rpc] add getfinalizedblockhash to return the current finalized block.Nov 21 2018, 20:19
Fabien commandeered this revision.Nov 22 2018, 15:21
Fabien edited reviewers, added: schancel; removed: Fabien.
Closed by commit rABC3d981bc03584: Finish conversion of rpc to use pushKV (authored by schancel, committed by Fabien). · Explain WhyNov 22 2018, 15:22
This revision was automatically updated to reflect the committed changes.
Fabien removed a child revision: D2114: [rpc] add getfinalizedblockhash to return the current finalized block.Nov 22 2018, 15:22

Revision Contents
Changeset List

PathSize
src/
10 lines
rpc/
58 lines
19 lines
33 lines
47 lines
19 lines
wallet/
29 lines

Diff 5815

View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...