Page MenuHomePhabricator

Finish conversion of rpc to use pushKV
ClosedPublic

Authored by Fabien on Nov 13 2018, 19:19.

Details

Summary

As per title. Fixes missed changes from D1990.

Test Plan
make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-pushkv
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3899
Build 5870: Bitcoin ABC Buildbot (legacy)
Build 5869: arc lint + arc unit

Event Timeline

src/wallet/db.cpp:355 make_pair => std::make_pair

src/qt/walletmodel.cpp
324 ↗(On Diff #5812)

std::make_pair

src/rest.cpp
632 ↗(On Diff #5812)

missed

src/rpc/blockchain.cpp
91 ↗(On Diff #5812)

missed

111 ↗(On Diff #5812)

dito

136 ↗(On Diff #5812)

dito

1123 ↗(On Diff #5812)

dito

src/rpc/mining.cpp
661 ↗(On Diff #5812)

dito

663 ↗(On Diff #5812)

dito

src/rpc/misc.cpp
116 ↗(On Diff #5812)

dito

119 ↗(On Diff #5812)

dito

132 ↗(On Diff #5812)

dito

248 ↗(On Diff #5812)

dito

272 ↗(On Diff #5812)

dito

src/rpc/net.cpp
473 ↗(On Diff #5812)

dito

496 ↗(On Diff #5812)

dito

579 ↗(On Diff #5812)

dito

586 ↗(On Diff #5812)

dito

590 ↗(On Diff #5812)

dito

592 ↗(On Diff #5812)

dito

src/rpc/rawtransaction.cpp
70 ↗(On Diff #5812)

dito

80 ↗(On Diff #5812)

dito

87 ↗(On Diff #5812)

dito

719 ↗(On Diff #5812)

dito

src/wallet/rpcwallet.cpp
2997 ↗(On Diff #5812)

dito

2999 ↗(On Diff #5812)

dito

3289 ↗(On Diff #5812)

dito

3296 ↗(On Diff #5812)

dito

schancel marked an inline comment as done.

Address feedback on missed push_back(Pair('s

Fabien requested changes to this revision.Nov 13 2018, 21:13
Fabien added inline comments.
src/rpc/mining.cpp
255

Missed

src/rpc/rawtransaction.cpp
117

missed

src/wallet/rpcwallet.cpp
1515

missed

1544

missed

3006

missed

3289

missed

This revision now requires changes to proceed.Nov 13 2018, 21:13
schancel marked an inline comment as done.

Fix remaining push_backs

src/rpc/mining.cpp
636 ↗(On Diff #5817)

this ; get transformed into :

Fabien requested changes to this revision.Nov 16 2018, 23:21
This revision now requires changes to proceed.Nov 16 2018, 23:21
This revision is now accepted and ready to land.Nov 21 2018, 20:12
Fabien edited reviewers, added: schancel; removed: Fabien.
This revision was automatically updated to reflect the committed changes.