Page MenuHomePhabricator
Differential D2114

[rpc] add getfinalizedblockhash to return the current finalized block
ClosedPublic
Actions

Authored by Fabien on Nov 21 2018, 20:06.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING146234984563: [rpc] add getfinalizedblockhash to return the current finalized block
rABC146234984563: [rpc] add getfinalizedblockhash to return the current finalized block
Summary

As per title. Add an API so that node operators can introspect the currently
finalized block in case they need to make manual adjustments.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getfinalizedblockhash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4035
Build 6141: Bitcoin ABC Buildbot (legacy)
Build 6140: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 21 2018, 20:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2018, 20:06
schancel changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 21 2018, 20:06
schancel updated this revision to Diff 5991.Nov 21 2018, 20:09

Add mising test

schancel edited the summary of this revision. (Show Details)Nov 21 2018, 20:19
schancel added a parent revision: D2064: Finish conversion of rpc to use pushKV.
schancel edited the summary of this revision. (Show Details)
schancel updated this revision to Diff 5992.Nov 21 2018, 20:22

Remove mistaken dependency on D2064

schancel edited the summary of this revision. (Show Details)Nov 21 2018, 20:23
schancel updated this revision to Diff 5994.Nov 21 2018, 20:44

Add missing null check

schancel updated this revision to Diff 5995.Nov 21 2018, 20:45

Remove unnecessary whitespace change

schancel updated this revision to Diff 6000.Nov 21 2018, 23:37

Fix test

Fabien added a subscriber: Fabien.Nov 22 2018, 00:07
Fabien added inline comments.
test/functional/abc-finalize-block.py
47 ↗(On Diff #6000)

Could alt_node.generate(AUTO_FINALIZATION_DEPTH) make the test more repeatable against maxreorgdepth values ?

deadalnix requested changes to this revision.Nov 22 2018, 00:15
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/rpc/blockchain.cpp
192 ↗(On Diff #6000)

If no block is finalized, returning null is more appropriate.

src/validation.h
639 ↗(On Diff #6000)

It seems like this should just return the CBlockIndex.

This revision now requires changes to proceed.Nov 22 2018, 00:15
Fabien commandeered this revision.Nov 22 2018, 14:24
Fabien added a reviewer: schancel.
Fabien updated this revision to Diff 6011.Nov 22 2018, 14:25

Update as per review

Fabien updated this revision to Diff 6012.Nov 22 2018, 14:49

GetFinalizedBlock returns CBlockIndex *

deadalnix accepted this revision.Nov 22 2018, 15:01
deadalnix added inline comments.
src/validation.cpp
2918 ↗(On Diff #6012)

prefix const

src/validation.h
639 ↗(On Diff #6012)

Prefix const

This revision is now accepted and ready to land.Nov 22 2018, 15:01
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 22 2018, 15:09
Fabien updated this revision to Diff 6013.Nov 22 2018, 15:11

const prefix

deadalnix requested changes to this revision.Nov 22 2018, 15:15
deadalnix added inline comments.
src/rpc/blockchain.cpp
193 ↗(On Diff #6013)

const prefix

This revision now requires changes to proceed.Nov 22 2018, 15:15
Fabien updated this revision to Diff 6014.Nov 22 2018, 15:16

Fix missing prefix

deadalnix accepted this revision.Nov 22 2018, 15:17
This revision is now accepted and ready to land.Nov 22 2018, 15:17
Fabien removed a parent revision: D2064: Finish conversion of rpc to use pushKV.Nov 22 2018, 15:22
Closed by commit rABC146234984563: [rpc] add getfinalizedblockhash to return the current finalized block (authored by schancel, committed by Fabien). · Explain WhyNov 22 2018, 15:26
This revision was automatically updated to reflect the committed changes.
teamcity added a subscriber: teamcity.Nov 22 2018, 17:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 22 2018, 17:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Nov 22 2018, 17:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4051: Diff 6011.Nov 22 2018, 17:18
teamcity added a comment.Nov 22 2018, 17:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Nov 22 2018, 17:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4052: Diff 6012.Nov 22 2018, 17:26
teamcity added a comment.Nov 22 2018, 17:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4053: Diff 6013.Nov 22 2018, 17:34
teamcity added a comment.Nov 22 2018, 17:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 22 2018, 17:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4054: Diff 6014.Nov 22 2018, 17:42

Revision Contents
Changeset List

PathSize
src/
rpc/
14 lines
2 lines
8 lines
test/
functional/
3 lines

Diff 5995

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-finalize-block.py

Loading...