Page MenuHomePhabricator
Differential D2128

Record when block was fully received
ClosedPublic
Actions

Authored by schancel on Nov 24 2018, 21:06.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGeb27c4cab519: Record when block was fully received
rABCeb27c4cab519: Record when block was fully received
Summary

As per title. This potentially enables punishment for block withholding
as per Jonathan Toomim's ideas.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
block-received-time (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4107
Build 6285: Bitcoin ABC Buildbot (legacy)
Build 6284: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 24 2018, 21:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2018, 21:06
teamcity added a subscriber: teamcity.Nov 24 2018, 21:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 24 2018, 21:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4102: Diff 6079.Nov 24 2018, 21:16
jasonbcox requested changes to this revision.Nov 24 2018, 23:57
jasonbcox added a subscriber: jasonbcox.

This diff never sets the block received time as described in the summary.

src/chain.h
100 ↗(On Diff #6079)

Block and header times should be in alphabetical order (swap them)

124 ↗(On Diff #6079)

Swap here too

143 ↗(On Diff #6079)

Swap here too

src/validation.cpp
3726 ↗(On Diff #6079)

This overwrites the header received time, which doesn't seem like the expected behavior at all.

This revision now requires changes to proceed.Nov 24 2018, 23:57
schancel marked 2 inline comments as done.Nov 25 2018, 00:17
schancel added inline comments.
src/chain.h
124 ↗(On Diff #6079)

Says who? None of the rest of this stuff is in alphabetical order.

src/validation.cpp
3726 ↗(On Diff #6079)

You are correct sir. Not sure wtf I was doing.

schancel updated this revision to Diff 6082.Nov 25 2018, 00:22

Correctly test BlockReceived time

teamcity added a comment.Nov 25 2018, 00:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 25 2018, 00:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4105: Diff 6082.Nov 25 2018, 00:32
schancel updated this revision to Diff 6083.Nov 25 2018, 00:42

Update ordering of variables

teamcity added a comment.Nov 25 2018, 00:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 6084.Nov 25 2018, 00:43

Update ordering in one more place

teamcity added a comment.Nov 25 2018, 00:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 25 2018, 00:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4106: Diff 6083.Nov 25 2018, 00:52
teamcity added a comment.Nov 25 2018, 00:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4107: Diff 6084.Nov 25 2018, 00:54
jasonbcox accepted this revision.Nov 26 2018, 18:56
This revision is now accepted and ready to land.Nov 26 2018, 18:56
Closed by commit rABCeb27c4cab519: Record when block was fully received (authored by schancel). · Explain WhyNov 26 2018, 21:45
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
18 lines
test/
25 lines
6 lines

Diff 6084

View Options

src/chain.h

Loading...
View Options

src/test/blockindex_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...