Page MenuHomePhabricator

Format the crypto library
ClosedPublic

Authored by deadalnix on Jun 22 2017, 16:24.

Details

Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cryptofmt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 392
Build 392: arc lint + arc unit

Event Timeline

freetrader added inline comments.
src/crypto/sha256.cpp
79

I feel the rounds below would be better off not broken over. Protect?

src/crypto/sha512.cpp
62

dito

This revision now requires changes to proceed.Jun 22 2017, 18:47
deadalnix edited edge metadata.
deadalnix added inline comments.
src/crypto/sha256.cpp
79

Really, the crappy thing here is the w0 += ... passed as argument. With it on the previous line, then there is no problem. I would just let the formatter do its job and we'll fix it if we think it is worth it later on.

src/crypto/sha512.cpp
62

Same :)

freetrader added inline comments.
src/crypto/sha256.cpp
79

ok

This revision is now accepted and ready to land.Jun 23 2017, 06:42
This revision was automatically updated to reflect the committed changes.