Page MenuHomePhabricator
Differential D252

Format the crypto library
ClosedPublic
Actions

Authored by deadalnix on Jun 22 2017, 16:24.

Details

Reviewers
freetrader
sickpig
awemany
kyuupichan
Group Reviewers
Restricted Project
Commits
rSTAGING0eee9524968a: Format the crypto library
rABC0eee9524968a: Format the crypto library
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cryptofmt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 392
Build 392: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 22 2017, 16:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2017, 16:24
freetrader requested changes to this revision.Jun 22 2017, 18:47
freetrader added inline comments.
src/crypto/sha256.cpp
79

I feel the rounds below would be better off not broken over. Protect?

src/crypto/sha512.cpp
62

dito

This revision now requires changes to proceed.Jun 22 2017, 18:47
deadalnix requested review of this revision.Jun 22 2017, 22:09
deadalnix edited edge metadata.
deadalnix added inline comments.
src/crypto/sha256.cpp
79

Really, the crappy thing here is the w0 += ... passed as argument. With it on the previous line, then there is no problem. I would just let the formatter do its job and we'll fix it if we think it is worth it later on.

src/crypto/sha512.cpp
62

Same :)

freetrader accepted this revision.Jun 23 2017, 06:42
freetrader added inline comments.
src/crypto/sha256.cpp
79

ok

This revision is now accepted and ready to land.Jun 23 2017, 06:42
Closed by commit rABC0eee9524968a: Format the crypto library (authored by deadalnix, committed by deadalnix). · Explain WhyJun 23 2017, 09:01
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
crypto/
56 lines
122 lines
50 lines
ctaes/
42 lines
8 lines
6 lines
8 lines
6 lines
7 lines
116 lines
7 lines
49 lines
7 lines
209 lines
7 lines
311 lines

Diff 627

View Options

src/crypto/aes.h

Loading...
View Options

src/crypto/aes.cpp

Loading...
View Options

src/crypto/common.h

Loading...
View Options

src/crypto/ctaes/ctaes.h

Loading...
View Options

src/crypto/hmac_sha256.h

Loading...
View Options

src/crypto/hmac_sha256.cpp

Loading...
View Options

src/crypto/hmac_sha512.h

Loading...
View Options

src/crypto/hmac_sha512.cpp

Loading...
View Options

src/crypto/ripemd160.h

Loading...
View Options

src/crypto/ripemd160.cpp

Loading...
View Options

src/crypto/sha1.h

Loading...
View Options

src/crypto/sha1.cpp

Loading...
View Options

src/crypto/sha256.h

Loading...
View Options

src/crypto/sha256.cpp

Loading...
View Options

src/crypto/sha512.h

Loading...
View Options

src/crypto/sha512.cpp

Loading...