Page MenuHomePhabricator
Differential D2213

Do not validate TTOR anymore
ClosedPublic
Actions

Authored by deadalnix on Dec 21 2018, 12:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGd1cf448cabaa: Do not validate TTOR anymore
rABCd1cf448cabaa: Do not validate TTOR anymore
Summary

We can limit ourself to accept transaction in any order before the fork point.

Test Plan
make check
./test/functional/test_runner.py -extended

Do full IBD

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cleanupttor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4340
Build 6745: Bitcoin ABC Buildbot (legacy)
Build 6744: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 21 2018, 12:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 12:21
Herald added a subscriber: schancel. · View Herald Transcript
Fabien requested changes to this revision.Dec 21 2018, 13:43
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
2199

This comment seems no longer necessary

This revision now requires changes to proceed.Dec 21 2018, 13:43
teamcity added a subscriber: teamcity.Dec 21 2018, 13:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 21 2018, 13:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4340: Diff 6390.Dec 21 2018, 13:57
deadalnix updated this revision to Diff 6409.Dec 22 2018, 16:44

Update comments

teamcity added a comment.Dec 22 2018, 16:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 22 2018, 16:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4353: Diff 6409.Dec 22 2018, 16:58
Fabien accepted this revision.Dec 22 2018, 18:04
This revision is now accepted and ready to land.Dec 22 2018, 18:04
Closed by commit rABCd1cf448cabaa: Do not validate TTOR anymore (authored by deadalnix). · Explain WhyDec 22 2018, 18:58
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2318: Remove magnetic anomaly transitional code, activate on block height.Jan 16 2019, 10:04

Revision Contents
Changeset List

PathSize
src/
25 lines
test/
functional/
11 lines
20 lines

Diff 6390

View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-checkdatasig-activation.py

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...