Page MenuHomePhabricator
Differential D2221

Fix getbestblockhash() called before the tip reaches the expected block
ClosedPublic
Actions

Authored by Fabien on Dec 23 2018, 13:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGc5f785875297: Fix getbestblockhash() called before the tip reaches the expected block
rABCc5f785875297: Fix getbestblockhash() called before the tip reaches the expected block
Summary

This fix a bug raised on CI (Teamcity #3004).
Analyzing the log shown that delay_node.getbestblockhash() was called
before its tip has been updated to alt_node_new_tip, which occured 3ms
later. Waiting for the tip to settle should avoid the issue.

Test Plan
./test/functional/test_runner.py abc-finalize-block

Diff Detail

Repository
rABC Bitcoin ABC
Branch
finalize_block_delay_node_fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4360
Build 6785: Bitcoin ABC Buildbot (legacy)
Build 6784: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 23 2018, 13:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2018, 13:32
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 23 2018, 13:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 23 2018, 13:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4360: Diff 6417!Dec 23 2018, 13:48
teamcity added a comment.Dec 23 2018, 14:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Dec 23 2018, 14:44
This revision is now accepted and ready to land.Dec 23 2018, 14:44
teamcity added a comment.Dec 23 2018, 14:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4360: Diff 6417.Dec 23 2018, 14:47
Closed by commit rABCc5f785875297: Fix getbestblockhash() called before the tip reaches the expected block (authored by Fabien). · Explain WhyDec 23 2018, 15:35
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 6417

View Options

test/functional/abc-finalize-block.py

Loading...