[wallet] Fix leak in CDB constructor
ClosedPublic
Actions

Authored by Fabien on Dec 28 2018, 21:59.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGb58465e258eb: [wallet] Fix leak in CDB constructor
rABCb58465e258eb: [wallet] Fix leak in CDB constructor

Summary

Now using a std::unique_ptr, the Db instance is correctly released
when CDB initialization fails.
The internal CDB state and mapFileUseCount are only mutated when
the CDB initialization succeeds.

Backport of core PR11492
Complete T220

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11492

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4374
Build 6813: Bitcoin ABC Buildbot (legacy)
Build 6812: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 28 2018, 21:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 28 2018, 21:59

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4374: Diff 6438.Dec 28 2018, 22:09

jasonbcox accepted this revision.Dec 28 2018, 22:18

This revision is now accepted and ready to land.Dec 28 2018, 22:18

Closed by commit rABCb58465e258eb: [wallet] Fix leak in CDB constructor (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyDec 28 2018, 23:00

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

wallet/

db.cpp

35 lines

Diff 6438

View Options

[wallet] Fix leak in CDB constructorClosedPublicActions