Page MenuHomePhabricator
Differential D2249

Update Copyright year to 2019
ClosedPublic
Actions

Authored by Mengerian on Jan 2 2019, 06:47.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING432b98d60252: Update Copyright year to 2019
rABC432b98d60252: Update Copyright year to 2019
Test Plan

Build and check Copyright year in running bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Branch
2019
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4399
Build 6863: Bitcoin ABC Buildbot (legacy)
Build 6862: arc lint + arc unit

Event Timeline

Mengerian created this revision.Jan 2 2019, 06:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 2 2019, 06:47
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 2 2019, 06:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mengerian updated this revision to Diff 6481.Jan 2 2019, 06:51
Mengerian removed a subscriber: teamcity.

Also update contrib/debian/copyright

teamcity added a comment.Jan 2 2019, 06:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mengerian retitled this revision from update Copyright year to 2019 to Update Copyright year to 2019.Jan 2 2019, 06:55
Mengerian updated this revision to Diff 6482.Jan 2 2019, 06:56
Mengerian retitled this revision from Update Copyright year to 2019 to update Copyright year to 2019.

Capitalize commit message

Mengerian retitled this revision from update Copyright year to 2019 to Update Copyright year to 2019.Jan 2 2019, 06:56
teamcity added a comment.Jan 2 2019, 06:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 2 2019, 06:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4397: Diff 6480.Jan 2 2019, 06:58
teamcity added a comment.Jan 2 2019, 07:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4398: Diff 6481.Jan 2 2019, 07:01
teamcity added a comment.Jan 2 2019, 07:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4399: Diff 6482.Jan 2 2019, 07:05
Fabien accepted this revision as: Fabien.Jan 2 2019, 14:22
This revision is now accepted and ready to land.Jan 2 2019, 14:22
Mengerian updated this revision to Diff 6484.Jan 2 2019, 18:29

Update COPYING to "Bitcoin developers" from "The Bitcoin ABC developers"
to make it consistent with the Copyright notices everywhere else.
Not sure if changing this is an issue.

Mengerian requested review of this revision.Jan 2 2019, 18:30
teamcity added a comment.Jan 2 2019, 18:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 2 2019, 18:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4401: Diff 6484.Jan 2 2019, 18:40
jasonbcox requested changes to this revision.Jan 2 2019, 18:43
jasonbcox added inline comments.
COPYING
3 ↗(On Diff #6484)

Add The

contrib/debian/copyright
7 ↗(On Diff #6484)

IMO, this line should have the "the"s to be consistent:
Copyright: 2009-2017, The Bitcoin Core Developers, 2017-2019 The Bitcoin Developers

This revision now requires changes to proceed.Jan 2 2019, 18:43
Mengerian updated this revision to Diff 6485.Jan 2 2019, 20:54
Mengerian marked 2 inline comments as done.

Add "the"s as per review feedback

teamcity added a comment.Jan 2 2019, 20:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 2 2019, 21:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4402: Diff 6485.Jan 2 2019, 21:05
deadalnix accepted this revision.Jan 3 2019, 10:54
jasonbcox accepted this revision.Jan 3 2019, 18:18
This revision is now accepted and ready to land.Jan 3 2019, 18:18
Closed by commit rABC432b98d60252: Update Copyright year to 2019 (authored by Mengerian). · Explain WhyJan 3 2019, 18:25
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
2 lines
contrib/
debian/
2 lines
src/
config/
4 lines

Diff 6482

View Options

COPYING

Loading...
View Options

configure.ac

Loading...
View Options

contrib/debian/copyright

Loading...
View Options

src/config/CMakeLists.txt

Loading...