Page MenuHomePhabricator
Differential D2268

Add calls to CWallet::BlockUntilSyncedToCurrentChain() in RPCs
ClosedPublic
Actions

Authored by deadalnix on Jan 8 2019, 01:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGef7ab2674294: Add calls to CWallet::BlockUntilSyncedToCurrentChain() in RPCs
rABCef7ab2674294: Add calls to CWallet::BlockUntilSyncedToCurrentChain() in RPCs
Summary

This prevents the wallet-RPCs-return-stale-info issue from being
re-introduced when new-block callbacks no longer happen in the
block-connection cs_main lock

This is extracted from Core's PR10286 commit 5d67a7868db188f7e43ce9028f215034d057790d

Depends on D2267

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
callblockuntil
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4445
Build 6954: Bitcoin ABC Buildbot (legacy)
Build 6953: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 8 2019, 01:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2019, 01:38
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 8 2019, 01:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 8 2019, 01:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4443: Diff 6548.Jan 8 2019, 01:47
deadalnix added a child revision: D2269: Use callbacks to cache whether wallet transactions are in mempool.Jan 8 2019, 02:02
Fabien requested changes to this revision.Jan 8 2019, 12:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcwallet.cpp
922 ↗(On Diff #6548)

Remove this line break

3594 ↗(On Diff #6548)

I think you wanted to move it down instead of calling it twice ?

This revision now requires changes to proceed.Jan 8 2019, 12:44
deadalnix updated this revision to Diff 6555.Jan 8 2019, 15:28

Remove eroneous call to BlockUntilSyncedToCurrentChain

src/wallet/rpcwallet.cpp
922 ↗(On Diff #6548)

clang-format insist on doing otherwise.

teamcity added a comment.Jan 8 2019, 15:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 8 2019, 15:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4445: Diff 6555.Jan 8 2019, 15:39
Fabien accepted this revision.Jan 14 2019, 13:57
This revision is now accepted and ready to land.Jan 14 2019, 13:57
deadalnix updated this revision to Diff 6644.Jan 14 2019, 14:38

rebase

teamcity added a comment.Jan 14 2019, 14:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4508: Diff 6644.Jan 14 2019, 14:49
teamcity added a comment.Jan 14 2019, 14:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCef7ab2674294: Add calls to CWallet::BlockUntilSyncedToCurrentChain() in RPCs (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJan 14 2019, 14:51
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in T436: Backport core PR 10286.May 24 2019, 15:26
markblundeberg added a subscriber: markblundeberg.Jun 30 2019, 18:42
markblundeberg added inline comments.
src/wallet/rpcwallet.cpp
925 ↗(On Diff #6645)

Note this actually came from #10807. https://github.com/bitcoin/bitcoin/pull/10807/files

Revision Contents
Changeset List

PathSize
src/
wallet/
107 lines

Diff 6555

View Options

src/wallet/rpcwallet.cpp

Loading...