Page MenuHomePhabricator

Add a CValidationInterface::TransactionRemovedFromMempool
ClosedPublic

Authored by deadalnix on Mon, Jan 7, 17:16.

Details

Summary

This is currently unused, but will by used by wallet to cache when
transactions are in the mempool, obviating the need for calls to
mempool from CWalletTx::InMempool()

This is extracted from Core's PR10286 commit a7d3936de8418522dbb161bfef31c234fc6c2503

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Mon, Jan 7, 17:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jan 7, 17:16
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox accepted this revision.Tue, Jan 8, 01:46
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validationinterface.cpp
139 ↗(On Diff #6542)

Looks like ptx should be a reference

This revision is now accepted and ready to land.Tue, Jan 8, 01:46
Closed by commit rABC8b4b0382782c: Add a CValidationInterface::TransactionRemovedFromMempool (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyTue, Jan 8, 14:27
This revision was automatically updated to reflect the committed changes.