Page MenuHomePhabricator
Differential D2263

Add a CValidationInterface::TransactionRemovedFromMempool
ClosedPublic
Actions

Authored by deadalnix on Jan 7 2019, 17:16.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING8b4b0382782c: Add a CValidationInterface::TransactionRemovedFromMempool
rABC8b4b0382782c: Add a CValidationInterface::TransactionRemovedFromMempool
Summary

This is currently unused, but will by used by wallet to cache when
transactions are in the mempool, obviating the need for calls to
mempool from CWalletTx::InMempool()

This is extracted from Core's PR10286 commit a7d3936de8418522dbb161bfef31c234fc6c2503

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
addcvimempool
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4438
Build 6941: Bitcoin ABC Buildbot (legacy)
Build 6940: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 7 2019, 17:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2019, 17:16
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 7 2019, 17:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 7 2019, 17:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4438: Diff 6542.Jan 7 2019, 17:27
deadalnix added a child revision: D2265: Call TransactionRemovedFromMempool in the CScheduler thread.Jan 8 2019, 01:01
jasonbcox accepted this revision.Jan 8 2019, 01:46
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validationinterface.cpp
139

Looks like ptx should be a reference

This revision is now accepted and ready to land.Jan 8 2019, 01:46
Closed by commit rABC8b4b0382782c: Add a CValidationInterface::TransactionRemovedFromMempool (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJan 8 2019, 14:27
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in T436: Backport core PR 10286.May 24 2019, 15:26

Revision Contents
Changeset List

PathSize
src/
2 lines
3 lines
18 lines
26 lines

Diff 6542

View Options

src/init.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...