Differential D2297

Upgrade clang-format to 7.0
ClosedPublic
Actions

Authored by deadalnix on Jan 11 2019, 20:57.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGf2de2629d33b: Upgrade clang-format to 7.0
rABCf2de2629d33b: Upgrade clang-format to 7.0

Summary

It does various things better. Version 5.0 and 6.0 have various regression on our codebase.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

clangformat7

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4494
Build 7051: Bitcoin ABC Buildbot (legacy)
Build 7050: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 11 2019, 20:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2019, 20:57

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4491: Diff 6621.Jan 11 2019, 21:08

jasonbcox retitled this revision from Upgrade clanf-format to 7.0 to Upgrade clang-format to 7.0.Jan 11 2019, 22:46

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jan 11 2019, 23:08

This revision is now accepted and ready to land.Jan 11 2019, 23:08

Harbormaster completed remote builds in B4494: Diff 6625.Jan 11 2019, 23:08

Closed by commit rABCf2de2629d33b: Upgrade clang-format to 7.0 (authored by deadalnix). · Explain WhyJan 11 2019, 23:18

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

.arclint

4 lines

src/

4 lines

5 lines

34 lines

6 lines

10 lines

6 lines

13 lines

6 lines

4 lines

consensus/

tx_verify.cpp

8 lines

crypto/

ctaes/

16 lines

19 lines

27 lines

13 lines

5 lines

178 lines

policy/

fees.cpp

28 lines

qt/

bitcoin.cpp

5 lines

bitcoinamountfield.cpp

20 lines

bitcoingui.h

4 lines

coincontroldialog.cpp

16 lines

10 lines

5 lines

16 lines

15 lines

test/

11 lines

15 lines

7 lines

10 lines

11 lines

rpc/

26 lines

5 lines

17 lines

40 lines

20 lines

5 lines

5 lines

script/

10 lines

8 lines

5 lines

12 lines

seeder/

bitcoin.cpp

6 lines

dns.cpp

3 lines

sync.cpp

5 lines

test/

cashaddrenc_tests.cpp

5 lines

crypto_tests.cpp

43 lines

miner_tests.cpp

56 lines

policyestimator_tests.cpp

44 lines

script_tests.cpp

9 lines

sigencoding_tests.cpp

12 lines

transaction_tests.cpp

33 lines

5 lines

5 lines

5 lines

5 lines

47 lines

wallet/

6 lines

5 lines

5 lines

131 lines

test/

crypto_tests.cpp

7 lines

wallet.cpp

22 lines

walletdb.cpp

5 lines

Diff 6625

View Options

.arclint

View Options

src/.clang-format

View Options

src/addrman.h

View Options

src/addrman.cpp

View Options

src/avalanche.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/bitcoind.cpp

View Options

src/blockencodings.cpp

View Options

src/chain.cpp

View Options

src/checkqueue.h

View Options

src/consensus/tx_verify.cpp

View Options

src/crypto/ctaes/ctaes.h

View Options

src/httpserver.cpp

View Options

src/init.cpp

View Options

src/miner.cpp

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/policy/fees.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoinamountfield.cpp

View Options

src/qt/bitcoingui.h

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/overviewpage.cpp

View Options

src/qt/platformstyle.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/test/uritests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletview.cpp

View Options

src/rest.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/scheduler.h

View Options

src/scheduler.cpp

View Options

src/script/script.cpp

View Options

src/script/scriptcache.cpp

View Options

src/script/sigcache.cpp

View Options

src/script/standard.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/seeder/dns.cpp

View Options

src/sync.cpp

View Options

src/test/cashaddrenc_tests.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/policyestimator_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sigencoding_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/timedata.cpp

View Options

src/torcontrol.cpp

View Options

src/txdb.cpp

View Options

src/txmempool.h

View Options

src/validation.cpp

View Options

src/wallet/fees.h

View Options

src/wallet/init.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/crypto_tests.cpp

View Options

src/wallet/wallet.cpp

View Options

Upgrade clang-format to 7.0ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6625

.arclint

src/.clang-format

src/addrman.h

src/addrman.cpp

src/avalanche.cpp

src/bitcoin-tx.cpp

src/bitcoind.cpp

src/blockencodings.cpp

src/chain.cpp

src/checkqueue.h

src/consensus/tx_verify.cpp

src/crypto/ctaes/ctaes.h

src/httpserver.cpp

src/init.cpp

src/miner.cpp

src/net.cpp

src/net_processing.cpp

src/policy/fees.cpp

src/qt/bitcoin.cpp

src/qt/bitcoinamountfield.cpp

src/qt/bitcoingui.h

src/qt/coincontroldialog.cpp

src/qt/overviewpage.cpp

src/qt/platformstyle.cpp

src/qt/rpcconsole.cpp

src/qt/sendcoinsdialog.cpp

src/qt/test/uritests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionview.cpp

src/qt/walletview.cpp

src/rest.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/scheduler.h

src/scheduler.cpp

src/script/script.cpp

src/script/scriptcache.cpp

src/script/sigcache.cpp

src/script/standard.cpp

src/seeder/bitcoin.cpp

src/seeder/dns.cpp

src/sync.cpp

src/test/cashaddrenc_tests.cpp

src/test/crypto_tests.cpp

src/test/miner_tests.cpp

src/test/policyestimator_tests.cpp

src/test/script_tests.cpp

src/test/sigencoding_tests.cpp

src/test/transaction_tests.cpp

src/timedata.cpp

src/torcontrol.cpp

src/txdb.cpp

src/txmempool.h

src/validation.cpp

src/wallet/fees.h

src/wallet/init.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/crypto_tests.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

Upgrade clang-format to 7.0
ClosedPublic
Actions

Revision Contents
Changeset List