Page MenuHomePhabricator

Add -walletdir parameter to specify custom wallet dir
ClosedPublic

Authored by Fabien on Jan 15 2019, 11:40.

Details

Summary

Backport 1/4 of core PR11466
(commits 0530ba0, 80c5cbc and parts of 8263f6a)

Note:
This PR first add changes to bitcoind.cpp, init.cpp and qt/bitcoin.cpp
(commit 0530ba0) then remove them in a later commit from the same PR
(8263f6a).
Unfortunately keeping this commits in different revisions would break
the cmake build when the wallet is disabled, in a way there is no easy
solution to prevent it. These 2 commits are mixed in the same revision
to avoid this. Because the mixed parts from 0530ba0 are reversion from
8263f6a, this should not make the diff more difficult to review.

Test Plan
../configure --disable-wallet && make check
../configure && make check
cmake -DBUILD_BITCOIN_WALLET=OFF -GNinja .. && ninja check
cmake -GNinja .. && ninja check

Run:

mkdir <wallet_path>
bitcoind -walletdir=<wallet_path>

Check that wallet.dat and db.log files are created in <wallet_path>

./test/functional/test_runner.py multiwallet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11466_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4524
Build 7111: Bitcoin ABC Buildbot (legacy)
Build 7110: arc lint + arc unit

Event Timeline

This revision now requires changes to proceed.Jan 15 2019, 12:03
Fabien retitled this revision from Add -walletdir parameter / create walletdir if datadir doesn't exist to Add -walletdir parameter to specify custom wallet dir.Jan 15 2019, 12:27
Fabien edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jan 15 2019, 12:42
This revision was automatically updated to reflect the committed changes.