Page MenuHomePhabricator
Differential D2331

Update max supported dependency versions in symbol-check.py
ClosedPublic
Actions

Authored by jasonbcox on Jan 16 2019, 19:50.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGb30292f93786: Update max supported dependency versions in symbol-check.py
rABCb30292f93786: Update max supported dependency versions in symbol-check.py
Summary

This fixes nightly builds, which are currently failing due to the recent addition of threading dependencies.

Need to bump glibc to at least 2.18 to support __cxa_thread_atexit_impl (introduced in D2245)
Bumping to this version should be safe and relatively non-disruptive,
as Jessie was released in 2015 and Trusty was released in 2014.

Test Plan

Run gitian build and verify check-symbols completes successfully in ./var/build.log

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4554
Build 7171: Bitcoin ABC Buildbot (legacy)
Build 7170: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 16 2019, 19:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2019, 19:50
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox planned changes to this revision.Jan 16 2019, 19:51
jasonbcox edited the summary of this revision. (Show Details)
teamcity added a subscriber: teamcity.Jan 16 2019, 19:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 16 2019, 20:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4554: Diff 6702.Jan 16 2019, 20:01
jasonbcox edited the test plan for this revision. (Show Details)Jan 17 2019, 00:02
jasonbcox requested review of this revision.Jan 17 2019, 00:05
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the summary of this revision. (Show Details)
Fabien requested changes to this revision.Jan 17 2019, 14:19
Fabien added inline comments.
contrib/devtools/symbol-check.py
28

The Ubuntu links are broken

This revision now requires changes to proceed.Jan 17 2019, 14:19
deadalnix accepted this revision.Jan 17 2019, 17:01
jasonbcox updated this revision to Diff 6716.Jan 17 2019, 17:37

Rebase + fix Ubuntu links

teamcity added a comment.Jan 17 2019, 17:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 17 2019, 17:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4563: Diff 6716.Jan 17 2019, 17:45
Fabien accepted this revision.Jan 18 2019, 10:34
This revision is now accepted and ready to land.Jan 18 2019, 10:34
Closed by commit rABCb30292f93786: Update max supported dependency versions in symbol-check.py (authored by jasonbcox). · Explain WhyJan 18 2019, 17:56
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
devtools/
30 lines

Diff 6702

View Options

contrib/devtools/symbol-check.py

Loading...