This include the -magneticanomalyactivationtime parameter and some
functional tests.
Depends on D2324
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING754afba59331: Remove magnetic anomaly transitional code, activate on block height
rABC754afba59331: Remove magnetic anomaly transitional code, activate on block height
make check ./test/functional/test_runner.py
Run IBD with checkpoint disabled and assumevalid=0 on mainnet and testnet
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- magnetic_remove_mtp
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4569 Build 7201: Bitcoin ABC Buildbot (legacy) Build 7200: arc lint + arc unit
Event Timeline
Comment Actions
You should also remove the mempool clearing code when we reorg accross the fork.
| src/consensus/activation.h | ||
|---|---|---|
| 20 ↗ | (On Diff #6676) | int32_t |
| src/consensus/tx_verify.cpp | ||
| 41 ↗ | (On Diff #6676) | Why ? |
| test/functional/abc-replay-protection.py | ||
| 110 ↗ | (On Diff #6676) | It's a good idea to do these in their own patches. It's easy wins that won't get blocked by anything else. |
| test/functional/abc-transaction-ordering.py | ||
| 20 ↗ | (On Diff #6676) | dito |
Comment Actions
Split commit (python tests are updated in D2324)
int => int32_t
Update transaction unit tests instead of removing them
Comment Actions
@deadalnix Didn't you already removed the mempool clearing code in D2213 ? Or are you talking about something else ?
Comment Actions
Absolutely, my bad. You are all set.
| src/chainparams.cpp | ||
|---|---|---|
| 303 ↗ | (On Diff #6690) | This does not looks like it is the proper block. See: https://explorer.bitcoin.com/tbch/block/0000000000000339f31e86d56c4a4a690632ba1fdd92f38942e678ac5abcf0de |
Comment Actions
The test plan for this change should definitively include an IBD with checkpoint disabled and assumevalid=0 for both mainnet and testnet.
Comment Actions
IBD on testnet is OK, still running on mainet.
I will request for review when it's done
Comment Actions
IBD on both testnet and mainnet were successful with the following parameters:
-checkpoints=0 -assumevalid=0