Page MenuHomePhabricator

Prevent TestNodeCLI.args mixups
ClosedPublic

Authored by Fabien on Jan 23 2019, 17:30.

Details

Summary

Change TestNodeCLI.call() to return a new instance instead of
modifying the existing instance. This way, it's possible to create
different cli objects that have their own options (for example
-rpcwallet options to connect to different wallets), and options set for
a single call (node.cli(options).method(args)) will no longer leak
into future calls.

Partial backport of core PR11970 (commit ca9085a)

Depends on D2396

Test Plan
./test/functional/test_runner.py interface_bitcoin_cli

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11970_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4669
Build 7401: Bitcoin ABC Buildbot (legacy)
Build 7400: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 24 2019, 14:37
This revision was automatically updated to reflect the committed changes.