Page MenuHomePhabricator
Differential D2400

Allow multiwallet.py to be used with --usecli
ClosedPublic
Actions

Authored by Fabien on Jan 23 2019, 17:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe6d1f16f8b74: Allow multiwallet.py to be used with --usecli
rABCe6d1f16f8b74: Allow multiwallet.py to be used with --usecli
Summary

Add test coverage for bitcoin-cli multiwallet calls.

Partial backport of core PR11970 (commit a14dbff)

Depends on D2399 and D2402

Test Plan
./test/function/test_runner.py

Ensure that wallet_multiwallet.py is run twice, the second time with
the --usecli argument

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11970_part5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4696
Build 7455: Bitcoin ABC Buildbot (legacy)
Build 7454: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2019, 17:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 17:52
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 23 2019, 17:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 23 2019, 18:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4672: Diff 6880.Jan 23 2019, 18:05
Fabien added a child revision: D2402: Fix test_runner.py wrong names for tests with arguments.Jan 23 2019, 19:25
Fabien updated this revision to Diff 6898.Jan 24 2019, 09:41

Rebase

Fabien added a child revision: D2407: Don't allow relative -walletdir paths.Jan 24 2019, 09:49
teamcity added a comment.Jan 24 2019, 09:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4684: Diff 6898.Jan 24 2019, 10:06
teamcity added a comment.Jan 24 2019, 10:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Jan 24 2019, 14:30
deadalnix added inline comments.
test/functional/test_runner.py
79 ↗(On Diff #6898)

This needs to be fixed.

This revision now requires changes to proceed.Jan 24 2019, 14:30
Fabien removed a child revision: D2402: Fix test_runner.py wrong names for tests with arguments.Jan 24 2019, 15:02
Fabien updated this revision to Diff 6907.Jan 24 2019, 15:11

Rebase

teamcity added a comment.Jan 24 2019, 15:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Jan 24 2019, 15:11
Fabien added a parent revision: D2402: Fix test_runner.py wrong names for tests with arguments.
teamcity added a comment.Jan 24 2019, 15:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4693: Diff 6907.Jan 24 2019, 15:24
deadalnix accepted this revision.Jan 24 2019, 15:41
deadalnix added inline comments.
test/functional/test_runner.py
79 ↗(On Diff #6907)

Use trailing coma

test/functional/wallet_multiwallet.py
30 ↗(On Diff #6907)

Why isn't this a lambda as in the original PR ?

This revision is now accepted and ready to land.Jan 24 2019, 15:41
Fabien added inline comments.Jan 24 2019, 15:51
test/functional/wallet_multiwallet.py
30 ↗(On Diff #6907)

This is an autopep8 rule, if the lambda is assigned, then you'd better have a function.
I don't understand why it didn't change data_dir and wallet_dir as well.

Fabien updated this revision to Diff 6914.Jan 24 2019, 15:53

Add trailing comma

teamcity added a comment.Jan 24 2019, 15:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 24 2019, 16:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4696: Diff 6914.Jan 24 2019, 16:06
deadalnix added inline comments.Jan 24 2019, 16:16
test/functional/wallet_multiwallet.py
30 ↗(On Diff #6907)

autopep8 is somewhat retarded.

Closed by commit rABCe6d1f16f8b74: Allow multiwallet.py to be used with --usecli (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyJan 24 2019, 17:13
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.May 27 2019, 11:54
Fabien added a commit: rSTAGINGe6d1f16f8b74: Allow multiwallet.py to be used with --usecli.Sep 18 2019, 22:05

Revision Contents
Changeset List

PathSize
test/
functional/
3 lines
4 lines
54 lines

Diff 6914

View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/timing.json

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...