Fix unused imports in contrib/ python scripts
ClosedPublic
Actions

Authored by Fabien on Jan 30 2019, 14:45.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING8fac3ab4fe1b: Fix unused imports in contrib/ python scripts
rABC8fac3ab4fe1b: Fix unused imports in contrib/ python scripts

Summary

Preparation before including a linter for this.

Test Plan

./contrib/testgen/gen_base58_test_vectors.py valid 5
./contrib/testgen/gen_base58_test_vectors.py invalid 5

In both case there should be no python error

Diff Detail

Repository

rABC Bitcoin ABC

Branch

unused_import_contrib

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4766
Build 7595: Bitcoin ABC Buildbot (legacy)
Build 7594: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 30 2019, 14:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2019, 14:45

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2451: Check for unused imports in *.py files.Jan 30 2019, 14:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4766: Diff 7020.Jan 30 2019, 15:01

jasonbcox accepted this revision.Jan 30 2019, 22:39

This revision is now accepted and ready to land.Jan 30 2019, 22:39

Closed by commit rABC8fac3ab4fe1b: Fix unused imports in contrib/ python scripts (authored by Fabien). · Explain WhyJan 31 2019, 11:03

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING8fac3ab4fe1b: Fix unused imports in contrib/ python scripts.Sep 18 2019, 22:10

Revision Contents
Changeset List

Path

Size

contrib/

testgen/

gen_base58_test_vectors.py

2 lines

Diff 7020

View Options

contrib/testgen/gen_base58_test_vectors.py

Fix unused imports in contrib/ python scriptsClosedPublicActions