This linter will warn if:
- The BOOST_FIXTURE_TEST_SUITE name does not match the file name
- The test name is not unique
Also add an entry in the dev notes.
Based on core PR12719 and PR12859
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGINGf952a1b9bf84: Add a linter to enfore unit tests file name/boost name match and unicity
rABCf952a1b9bf84: Add a linter to enfore unit tests file name/boost name match and unicity
Should return nothing:
./test/lint/lint-tests.sh
Rename the BOOST_FIXTURE_TEST_SUITE name in
src/wallet/test/wallet_crypto_tests.cpp to crypto_tests.
./test/lint/lint-tests.sh
Check the mismatch and the duplicata are detected
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- linter_tests_names
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4940 Build 7943: Bitcoin ABC Buildbot (legacy) Build 7942: arc lint + arc unit