Page MenuHomePhabricator
Differential D2556

Reset default -g -O2 flags when enable debug
ClosedPublic
Actions

Authored by sickpig on Feb 15 2019, 15:17.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING74fdb9ee4424: Reset default -g -O2 flags when enable debug
rABC74fdb9ee4424: Reset default -g -O2 flags when enable debug
Summary

9882d1f044133832b3c0809676d5f26a861b9f44 Reset default -g -O2 flags when enable debug (Chun Kuan Lee)

Pull request description:

The default CXXFLAGS is -g -O2, this should not appear when enable debug.
fixes #13432

Tree-SHA512: 79447f3e1fab9e6cd12f5ca49b3d42187e856e0c159ed01140ea93d6ef1fbb1af3d65b338308566330491052c0177d12abe26796513502ddde31692665a0dbb4

This is a port of core PR #13445

Test Plan

./autogen.sh && ./configure --enable-debug then check that CXXFLAGS starts with "-g3 -O0" and does not contain "-O2`

Diff Detail

Repository
rABC Bitcoin ABC
Branch
port-pr13445
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4998
Build 8059: Bitcoin ABC Buildbot (legacy)
Build 8058: arc lint + arc unit

Event Timeline

sickpig created this revision.Feb 15 2019, 15:17
Herald added a subscriber: schancel. · View Herald TranscriptFeb 15 2019, 15:17
teamcity added a subscriber: teamcity.Feb 15 2019, 15:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 15 2019, 15:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4998: Diff 7358.Feb 15 2019, 15:32
Fabien accepted this revision.Feb 15 2019, 15:35
This revision is now accepted and ready to land.Feb 15 2019, 15:35
deadalnix accepted this revision.Feb 15 2019, 15:40
Closed by commit rABC74fdb9ee4424: Reset default -g -O2 flags when enable debug (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by sickpig). · Explain WhyFeb 15 2019, 16:29
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2561: Make --enable-debug to pick better options.Feb 16 2019, 15:36
Fabien mentioned this in rABC2534b72cc113: Make --enable-debug to pick better options.Feb 19 2019, 17:45
sickpig added a commit: rSTAGING74fdb9ee4424: Reset default -g -O2 flags when enable debug.Sep 18 2019, 22:25
Fabien mentioned this in rSTAGING2534b72cc113: Make --enable-debug to pick better options.Sep 18 2019, 22:27

Revision Contents
Changeset List

PathSize
4 lines

Diff 7358

View Options

configure.ac

Loading...