Page MenuHomePhabricator

Add a test for signrawtransaction with various sighashes parameters
ClosedPublic

Authored by Fabien on Feb 16 2019, 14:09.

Details

Summary

While reviewing D2007 @jasonbcox raised that there was not test for the
various errors thrown when signrawtransaction is called with an
invalid sighash parameter.
This diff adds a functional test case which check the output of
signrawtransaction against valid sighashes, invalid sighashes and
sighashes missing the FORKID flag.

Test Plan
./test/functional/test_runner.py rpc_signrawtransaction

Diff Detail

Repository
rABC Bitcoin ABC
Branch
signrawtransaction_sighashes_test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5007
Build 8077: Bitcoin ABC Buildbot (legacy)
Build 8076: arc lint + arc unit