Page MenuHomePhabricator
Differential D2568

Update feature_* functional tests to use the new .format() method
ClosedPublic
Actions

Authored by Fabien on Feb 19 2019, 12:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING0a50f6c91a53: Update feature_* functional tests to use the new .format() method
rABC0a50f6c91a53: Update feature_* functional tests to use the new .format() method
Summary

Avoid using % to format strings, switch to the new method instead.

Test Plan
./test/functional/test_runner.py feature_assumevalid feature_cltv

feature_dbcrash feature_dersig feature_minchainwork
feature_notifications feature_proxy feature_pruning

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_python_format_feature
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5019
Build 8101: Bitcoin ABC Buildbot (legacy)
Build 8100: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 19 2019, 12:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2019, 12:41
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 19 2019, 12:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5019: Diff 7387.Feb 19 2019, 12:56
teamcity added a comment.Feb 19 2019, 12:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Feb 19 2019, 14:25
This revision is now accepted and ready to land.Feb 19 2019, 14:25
Closed by commit rABC0a50f6c91a53: Update feature_* functional tests to use the new .format() method (authored by Fabien). · Explain WhyFeb 19 2019, 17:37
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING0a50f6c91a53: Update feature_* functional tests to use the new .format() method.Sep 18 2019, 22:26
markblundeberg mentioned this in D5137: [tests] fix formatting in feature_dbcrash.Feb 3 2020, 11:39
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC9ddda8735669: [tests] fix formatting in feature_dbcrash.Feb 3 2020, 11:48
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING9ddda8735669: [tests] fix formatting in feature_dbcrash.Apr 7 2020, 22:46

Revision Contents
Changeset List

Diff 7387

View Options

test/functional/feature_assumevalid.py

Loading...
View Options

test/functional/feature_cltv.py

Loading...
View Options

test/functional/feature_dbcrash.py

Loading...
View Options

test/functional/feature_dersig.py

Loading...
View Options

test/functional/feature_minchainwork.py

Loading...
View Options

test/functional/feature_notifications.py

Loading...
View Options

test/functional/feature_proxy.py

Loading...
View Options

test/functional/feature_pruning.py

Loading...