Page MenuHomePhabricator
Differential D2642

rpc: work-around an upstream libevent bug
ClosedPublic
Actions

Authored by nakihito on Mar 4 2019, 20:52.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc9de86eddb4a: rpc: work-around an upstream libevent bug
rABCc9de86eddb4a: rpc: work-around an upstream libevent bug
Summary

A rare race condition may trigger while awaiting the body of a message, see
upsteam commit 5ff8eb26371c4dc56f384b2de35bea2d87814779 for details.

This may fix some reported rpc hangs/crashes.

Backport of Bitcoin Core PR#11593.
Completes T466.

Test Plan
make check
test_runner.py

Following the only documented attempt I could find for replicating the bug: https://github.com/bitcoin/bitcoin/pull/11593#issuecomment-341489496
Running bitcoind -regtest in with while true; do curl -XGET --data-binary . 127.0.0.1:18444; done while doing rpc commands
This should output curl: (52) Empty reply from server (bug would rarely cause a crash)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BackportPR11593
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5137
Build 8337: Bitcoin ABC Buildbot (legacy)
Build 8336: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 4 2019, 20:52
Owners added a reviewer: Restricted Owners Package.Mar 4 2019, 20:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 4 2019, 20:52
Herald added a subscriber: schancel. · View Herald Transcript
nakihito edited the summary of this revision. (Show Details)Mar 4 2019, 20:53
nakihito edited the test plan for this revision. (Show Details)
teamcity added a subscriber: teamcity.Mar 4 2019, 20:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Mar 4 2019, 20:54
teamcity added a comment.Mar 4 2019, 21:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5131: Diff 7578.Mar 4 2019, 21:06
jasonbcox requested changes to this revision.Mar 4 2019, 21:22

Looks like you missed the second commit in the PR: https://github.com/bitcoin/bitcoin/pull/11593/commits/97932cd2689659addfbb58dc6148928b73af3bd0

This revision now requires changes to proceed.Mar 4 2019, 21:22
nakihito updated this revision to Diff 7586.Mar 4 2019, 22:06

Included second commit: https://github.com/bitcoin/bitcoin/pull/11593/commits/97932cd2689659addfbb58dc6148928b73af3bd0

teamcity added a comment.Mar 4 2019, 22:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 4 2019, 22:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5137: Diff 7586.Mar 4 2019, 22:20
jasonbcox accepted this revision.Mar 4 2019, 22:57
This revision is now accepted and ready to land.Mar 4 2019, 22:57
Closed by commit rABCc9de86eddb4a: rpc: work-around an upstream libevent bug (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by nakihito). · Explain WhyMar 4 2019, 23:04
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGc9de86eddb4a: rpc: work-around an upstream libevent bug.Sep 18 2019, 22:38

Revision Contents
Changeset List

PathSize
src/
32 lines

Diff 7586

View Options

src/httpserver.cpp

Loading...