Page MenuHomePhabricator

Partial backport of Core PR9681 to add CWallet::SignTransaction
ClosedPublic

Authored by jasonbcox on Mar 8 2019, 18:56.

Details

Summary

Partial backport (only wallet.* changes in PR9681)
https://github.com/bitcoin/bitcoin/pull/9681/files
Completes T547
Although the function is currently unused, it appears to be used in future backports.
We can remove it later if it proves not useful.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr9681
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5195
Build 8453: Bitcoin ABC Buildbot (legacy)
Build 8452: arc lint + arc unit

Event Timeline

deadalnix added inline comments.
src/wallet/wallet.cpp
2742

There is no point manipulation Amount by reference.

This revision is now accepted and ready to land.Mar 8 2019, 21:24
src/wallet/wallet.cpp
2742

Ya this is silly. I'll fix it before landing.

Removed reference on Amount

This revision was automatically updated to reflect the committed changes.