Differential D2675

Partial backport of Core PR9681 to add CWallet::SignTransaction
ClosedPublic
Actions

Authored by jasonbcox on Mar 8 2019, 18:56.

Tags

None

Subscribers

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING34bfae7054a4: Partial backport of Core PR9681 to add CWallet::SignTransaction
rABC34bfae7054a4: Partial backport of Core PR9681 to add CWallet::SignTransaction

Summary

Partial backport (only wallet.* changes in PR9681)
https://github.com/bitcoin/bitcoin/pull/9681/files
Completes T547
Although the function is currently unused, it appears to be used in future backports.
We can remove it later if it proves not useful.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr9681

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5197
Build 8457: Bitcoin ABC Buildbot (legacy)
Build 8456: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 8 2019, 18:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2019, 18:56

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5195: Diff 7663.Mar 8 2019, 19:12

deadalnix accepted this revision.Mar 8 2019, 21:24

deadalnix added inline comments.

src/wallet/wallet.cpp
2742 ↗	(On Diff #7663)	There is no point manipulation Amount by reference.

This revision is now accepted and ready to land.Mar 8 2019, 21:24

jasonbcox added inline comments.Mar 8 2019, 22:33

src/wallet/wallet.cpp
2742 ↗	(On Diff #7663)	Ya this is silly. I'll fix it before landing.

Removed reference on Amount

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5197: Diff 7665.Mar 8 2019, 22:59

jasonbcox added a child revision: D2677: Wallet: Refactor FundTransaction to accept parameters via CCoinControl.Mar 8 2019, 23:13

Closed by commit rABC34bfae7054a4: Partial backport of Core PR9681 to add CWallet::SignTransaction (authored by jasonbcox). · Explain WhyMar 11 2019, 15:42

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING34bfae7054a4: Partial backport of Core PR9681 to add CWallet::SignTransaction.Sep 18 2019, 22:41

Revision Contents
Changeset List

Path

Size

src/

wallet/

6 lines

26 lines

Diff 7665

src/wallet/wallet.h

Loading...

src/wallet/wallet.cpp

Loading...