Merge #11027: [RPC] Only return hex field once in getrawtransaction
ClosedPublic
Actions

Authored by jasonbcox on Mar 19 2019, 17:08.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGe3b6fe0ed1ba: Merge #11027: [RPC] Only return hex field once in getrawtransaction
rABCe3b6fe0ed1ba: Merge #11027: [RPC] Only return hex field once in getrawtransaction

Summary

6bbdafc Pass serialization flags and whether to include hex to TxToUniv (Andrew Chow)
e029c6e Only return hex field once in getrawtransaction (Andrew Chow)

Pull request description:

The hex is already returned in `TxToUniv()`, no need to give it out a second time in getrawtransaction itself.

Tree-SHA512: 270289f2d6dea37f51f5a42db3dae5debdbe83c6b504fccfd3391588da986ed474592c6655d522dc51022d4b08fa90ed1ebb249afe036309f95adfe3652cb262

Backport of Core PR 11027
https://github.com/bitcoin/bitcoin/pull/11027
Completes T564

Test Plan

ninja check
test_runner.py

Run bitcoin-cli <txid> 1 and ensure that there is a single top-level "hex" field in the returned JSON.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr11027

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5249
Build 8561: Bitcoin ABC Buildbot (legacy)
Build 8560: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 19 2019, 17:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2019, 17:09

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5249: Diff 7749.Mar 19 2019, 17:25

Note to reviewers:
If you try to reproduce the described problem, you will not be able to do so.
This is because this fixes is against an older version of univalue. Our current version will prevent inserting the same key twice, thus masking the duplicated entry.
You can find the library update commit and the diff between the versions here search for pushKV in univalue.cpp.

Note 2 : even if there is no issue to fix, this diff impacts the output by moving the "hex" field from the beginning to the near end of the JSON. This should have no impact if proper JSON decoding is used.

Fabien accepted this revision.Mar 20 2019, 12:24

Fabien edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Mar 20 2019, 12:25

Closed by commit rABCe3b6fe0ed1ba: Merge #11027: [RPC] Only return hex field once in getrawtransaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMar 20 2019, 16:29

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGINGe3b6fe0ed1ba: Merge #11027: [RPC] Only return hex field once in getrawtransaction.Sep 18 2019, 22:45