Differential D2857

Use angle bracket in include for src (part 3)
ClosedPublic
Actions

Authored by Fabien on Apr 22 2019, 12:46.

Tags

None

Subscribers

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGd96e9c6f3e05: Use angle bracket in include for src (part 3)
rABCd96e9c6f3e05: Use angle bracket in include for src (part 3)

Summary

As per title

Partial backport of PR11651

Test Plan

make check
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11651_part26

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5553
Build 9168: Bitcoin ABC Buildbot (legacy)
Build 9167: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 22 2019, 12:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2019, 12:46

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5553: Diff 8201.Apr 22 2019, 12:59

jasonbcox requested changes to this revision.Apr 22 2019, 17:01

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/dstencode.h
9	separating line between system libs and internal dependencies
src/fs.cpp
1	Nit: This file needs a copyright notice
src/init.cpp
53	system libs section should be last
54	this newline shouldn't exist so that csignal is with the other system libs

This revision now requires changes to proceed.Apr 22 2019, 17:01

Fix ordering + missing copyright

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5562: Diff 8211.Apr 22 2019, 18:05

jasonbcox accepted this revision.Apr 22 2019, 18:47

This revision is now accepted and ready to land.Apr 22 2019, 18:47

Closed by commit rABCd96e9c6f3e05: Use angle bracket in include for src (part 3) (authored by Fabien). · Explain WhyApr 22 2019, 19:22

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48

Fabien added a commit: rSTAGINGd96e9c6f3e05: Use angle bracket in include for src (part 3).Sep 18 2019, 23:05

Revision Contents
Changeset List

Path

Size

src/

core_memusage.h

6 lines

20 lines

24 lines

14 lines

11 lines

4 lines

6 lines

13 lines

4 lines

6 lines

2 lines

6 lines

12 lines

9 lines

4 lines

28 lines

22 lines

80 lines

8 lines

12 lines

Diff 8201

src/core_memusage.h

Loading...

src/core_read.cpp

Loading...

src/core_write.cpp

Loading...

src/dbwrapper.h

Loading...

src/dbwrapper.cpp

Loading...

src/diskblockpos.h

Loading...

src/dstencode.h

Loading...

src/dstencode.cpp

Loading...

src/feerate.h

Loading...

src/feerate.cpp

Loading...

src/fs.cpp

Loading...

src/globals.cpp

Loading...

src/hash.h

Loading...

src/hash.cpp

Loading...

src/httprpc.h

Loading...

src/httprpc.cpp

Loading...

src/httpserver.cpp

Loading...

src/init.cpp

Loading...

src/key.h

Loading...

src/key.cpp

Loading...