Page MenuHomePhabricator
Differential D2870

Use angle bracket in include for wallet test
ClosedPublic
Actions

Authored by Fabien on Apr 23 2019, 07:39.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGd97910652534: Use angle bracket in include for wallet test
rABCd97910652534: Use angle bracket in include for wallet test
Summary

As per title

Partial backport of PR11651

Depends on D2869

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11651_part22
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5581
Build 9224: Bitcoin ABC Buildbot (legacy)
Build 9223: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 23 2019, 07:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2019, 07:39
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 23 2019, 07:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B5579: Diff 8238!Apr 23 2019, 07:48
teamcity added a comment.Apr 23 2019, 07:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Fabien updated this revision to Diff 8240.Apr 23 2019, 08:09

Depends on D2869

Fabien edited the summary of this revision. (Show Details)Apr 23 2019, 08:09
Fabien added a parent revision: D2869: Use angle bracket in include for wallet.
teamcity added a comment.Apr 23 2019, 08:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 23 2019, 08:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B5581: Diff 8240!Apr 23 2019, 08:18
Fabien planned changes to this revision.Apr 23 2019, 08:35
Fabien updated this revision to Diff 8242.Apr 23 2019, 10:20

Rebase

teamcity added a comment.Apr 23 2019, 10:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 23 2019, 10:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5583: Diff 8242.Apr 23 2019, 10:34
jasonbcox requested changes to this revision.Apr 24 2019, 22:46
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/test/wallet_tests.cpp
12 ↗(On Diff #8242)

Similar to the changes in walletdb_tests.cpp, these three wallet/ includes should be in their own section above this one.

This revision now requires changes to proceed.Apr 24 2019, 22:46
jasonbcox accepted this revision.Apr 25 2019, 15:35

Realized my comment isn't really standardizable across all source files, so ignore me.

This revision is now accepted and ready to land.Apr 25 2019, 15:35
Closed by commit rABCd97910652534: Use angle bracket in include for wallet test (authored by Fabien). · Explain WhyApr 25 2019, 15:43
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48
Fabien added a commit: rSTAGINGd97910652534: Use angle bracket in include for wallet test.Sep 18 2019, 23:08

Revision Contents
Changeset List

Diff 8240

View Options

src/wallet/test/accounting_tests.cpp

Loading...
View Options

src/wallet/test/wallet_crypto_tests.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.h

Loading...
View Options

src/wallet/test/wallet_test_fixture.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/test/walletdb_tests.cpp

Loading...