Page MenuHomePhabricator
Differential D2873

serialize: Serialization support for big-endian 32-bit ints.
ClosedPublic
Actions

Authored by markblundeberg on Apr 24 2019, 15:20.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Maniphest Tasks
T589: BIP157 & BIP158 backports
Commits
rSTAGINGe8c680bd5840: serialize: Serialization support for big-endian 32-bit ints.
rABCe8c680bd5840: serialize: Serialization support for big-endian 32-bit ints.
Summary

backport of a small commit from BIP157 PR 14121

2ad2338ef serialize: Serialization support for big-endian 32-bit ints.

Test Plan

no tests included

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bip157a
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5592
Build 9246: Bitcoin ABC Buildbot (legacy)
Build 9245: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Apr 24 2019, 15:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2019, 15:20
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 24 2019, 15:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T589: BIP157 & BIP158 backports.Apr 24 2019, 15:22
teamcity added a comment.Apr 24 2019, 15:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5592: Diff 8258.Apr 24 2019, 15:35
jasonbcox requested changes to this revision.Apr 24 2019, 23:15
jasonbcox added a subscriber: jasonbcox.

I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?

This revision now requires changes to proceed.Apr 24 2019, 23:15
markblundeberg requested review of this revision.Apr 25 2019, 00:19
In D2873#68026, @jasonbcox wrote:

I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?

In src/index/blockfilterindex.cpp (looks like github hid it for being too long).

jasonbcox accepted this revision.Apr 25 2019, 01:35

Although this backport looks ok, I do think we should investigate test coverage in the future

This revision is now accepted and ready to land.Apr 25 2019, 01:35
Closed by commit rABCe8c680bd5840: serialize: Serialization support for big-endian 32-bit ints. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyApr 25 2019, 19:45
This revision was automatically updated to reflect the committed changes.
markblundeberg added a comment.Apr 25 2019, 19:47
In D2873#68039, @jasonbcox wrote:

Although this backport looks ok, I do think we should investigate test coverage in the future

Agree!

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGe8c680bd5840: serialize: Serialization support for big-endian 32-bit ints..Sep 18 2019, 23:09

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 8258

View Options

src/serialize.h

Loading...