Page MenuHomePhabricator

Update prevector
ClosedPublic

Authored by deadalnix on May 16 2019, 22:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING9c76f4564b0b: Update prevector
rABC9c76f4564b0b: Update prevector
Summary
  • Backport Core PR14266 : Use initializer instead of initializing fields explicitely in every constructors.
  • Backport Core PR14715
  • Backport Core PR13711
  • Backport Core PR14031
  • Backport Core PR14651
Test Plan

Run unit tests with ubsan enabled.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
prevecrefac
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5876
Build 9812: Bitcoin ABC Buildbot (legacy)
Build 9811: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.May 17 2019, 18:36
Fabien added a subscriber: Fabien.

You forgot to include the removal in compat.h, that would break the build with gcc 4.x.
Also you can add PR14651 and PR14031 to the list of backports included in this diff.

src/bench/prevector.cpp
48

Remove

This revision now requires changes to proceed.May 17 2019, 18:36

Rebase and remove empty line.

Fabien requested changes to this revision.May 24 2019, 06:45

GCC4.x doesn't do C++14 That's a good point. So I guess the special case targeting it specifically can be removed ?

The initializers changes should be in their own diff.

Please add PR14651 and PR14031 in the summary for reference.

src/bench/prevector.cpp
18 ↗(On Diff #8818)

This block is moved from compat.h in the PR, but here it is duplicated.

This revision now requires changes to proceed.May 24 2019, 06:45

Remove IS_TRIVIALLY_CONSTRUCTIBLE from compat.h

From offline discussion: the Use initializer instead of initializing fields explicitely in every constructors. is from PR14266

This revision is now accepted and ready to land.May 27 2019, 14:34
This revision was automatically updated to reflect the committed changes.