Page MenuHomePhabricator
Differential D3067

Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator
ClosedPublic
Actions

Authored by nakihito on May 17 2019, 20:34.

Details

Reviewers
jasonbcox
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING1fc4b4a46602: Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator
rABC1fc4b4a46602: Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator
Summary

22b4aae02 [arith_uint256] Avoid unnecessary this-copy using prefix operator (Karl-Johan Alm)

Pull request description:

I noticed while profiling a related project that `operator-()` actually calls the `base_uint` constructor, which is because the postfix operator version of `operator++` (used in `operator-()`) creates a copy of `this` and returns it.

Tree-SHA512: d9a2665caa3d93f064cdeaf1c6fada101b9943bb53d93ccac6d9a0edac20279d2e921349e30239039c71e0a9629e45c29ec9f10d8d7499e936cdba6cb7c3c3eb

Backport of Core PR 12564
https://github.com/bitcoin/bitcoin/pull/12564

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12564
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5889
Build 9838: Bitcoin ABC Buildbot (legacy)
Build 9837: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 8727

View Options

src/arith_uint256.h

Loading...