Page MenuHomePhabricator
Differential D3107

Merge #10308: [wallet] Securely erase potentially sensitive keys/values
ClosedPublic
Actions

Authored by jasonbcox on May 24 2019, 19:42.

Details

Reviewers
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGf3bbfc8e6e74: Merge #10308: [wallet] Securely erase potentially sensitive keys/values
rABCf3bbfc8e6e74: Merge #10308: [wallet] Securely erase potentially sensitive keys/values
Summary

6c914ac [wallet] Securely erase potentially sensitive keys/values (Thomas Snider)

Tree-SHA512: 071d88c4093108d4e4eced35a6ffcebe3f499798194f5b1be661ffa5b78b5f55311667f6d2a72758d85290f61f958381ee95d380b9045ca18e9e1875f0e686c8

Backport Core PR10308
https://github.com/bitcoin/bitcoin/pull/10308/files

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10308
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5975
Build 10010: Bitcoin ABC Buildbot (legacy)
Build 10009: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 24 2019, 19:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2019, 19:42
teamcity added a comment.May 24 2019, 19:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 24 2019, 19:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5975: Diff 8859.May 24 2019, 19:57
markblundeberg accepted this revision.May 24 2019, 21:17
markblundeberg added a subscriber: markblundeberg.

Cool! TIL memset 0 is not necessarily good enough.

From the PR discussion it sounds like this doesn't guarantee much on its own, but presumably you'll be backporting PR11196 soon as well. :-)

This revision is now accepted and ready to land.May 24 2019, 21:17
Closed by commit rABCf3bbfc8e6e74: Merge #10308: [wallet] Securely erase potentially sensitive keys/values (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 27 2019, 06:13
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCf3bbfc8e6e74: Merge #10308: [wallet] Securely erase potentially sensitive keys/values.
jasonbcox added a commit: rSTAGINGf3bbfc8e6e74: Merge #10308: [wallet] Securely erase potentially sensitive keys/values.Sep 18 2019, 23:47

Revision Contents
Changeset List

PathSize
src/
support/
1 line
wallet/
50 lines

Diff 8859

View Options

src/support/cleanse.h

Loading...
View Options

src/wallet/db.h

Loading...