Page MenuHomePhabricator
Differential D3219

Merge #9890: Add a button to open the config file in a text editor
ClosedPublic
Actions

Authored by jasonbcox on Jun 5 2019, 18:52.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING76041fb6f529: Merge #9890: Add a button to open the config file in a text editor
rABC76041fb6f529: Merge #9890: Add a button to open the config file in a text editor
Summary

9ab9e7d Add a button to open the config file in a text editor (Eric Shaw Jr)

Tree-SHA512: 1d13be9ac788a05a5116dbb3e1136ef65732dc2b5634547860612658109668922c9ea80b77bde4ba5beaa762d54f2a986a6064d4e34e963cdcd3d126a4eced37

Backport of Core PR9890
https://github.com/bitcoin/bitcoin/pull/9890/files

Test Plan
make check
bitcoin-qt
# Settings -> Options
# Click button to open configuration file
# See popup info window -> click OK
# Config file should open in the default editor

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr9890
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6191
Build 10429: Bitcoin ABC Buildbot (legacy)
Build 10428: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 5 2019, 18:52
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 5 2019, 18:52
teamcity added a comment.Jun 5 2019, 18:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a child revision: D3220: Merge #11198: [Qt] Fix display of package name on 'open config file' tooltip.Jun 5 2019, 18:55
teamcity added a comment.Jun 5 2019, 19:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6166: Diff 9164.Jun 5 2019, 19:03
Fabien requested changes to this revision.Jun 6 2019, 08:01
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/guiutil.cpp
434 ↗(On Diff #9164)

boost::filesystem::path => fs::path

437 ↗(On Diff #9164)

Dito

This revision now requires changes to proceed.Jun 6 2019, 08:01
jasonbcox updated this revision to Diff 9213.Jun 6 2019, 21:14

Rebase + boost -> fs

teamcity added a comment.Jun 6 2019, 21:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6191: Diff 9213.Jun 6 2019, 21:25
teamcity added a comment.Jun 6 2019, 21:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jun 6 2019, 22:39
jasonbcox added inline comments.Jun 6 2019, 23:10
src/qt/guiutil.cpp
434 ↗(On Diff #9164)

Cleaned up the includes at the top of this file as well: D3242

Fabien accepted this revision.Jun 7 2019, 09:09
This revision is now accepted and ready to land.Jun 7 2019, 09:09
Closed by commit rABC76041fb6f529: Merge #9890: Add a button to open the config file in a text editor (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by jasonbcox). · Explain WhyJun 7 2019, 17:23
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC76041fb6f529: Merge #9890: Add a button to open the config file in a text editor.
jasonbcox added a commit: rSTAGING76041fb6f529: Merge #9890: Add a button to open the config file in a text editor.Sep 19 2019, 00:08
nakihito mentioned this in D5057: Merge #13982: refactor: use fs:: over boost::filesystem::.Jan 23 2020, 19:03
nakihito mentioned this in rABC8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::.Jan 24 2020, 18:02
nakihito mentioned this in rSTAGING8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::.Apr 7 2020, 22:38

Revision Contents
Changeset List

PathSize
src/
qt/
forms/
102 lines
3 lines
17 lines
1 line
16 lines

Diff 9213

View Options

src/qt/forms/optionsdialog.ui

Loading...
View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/optionsdialog.h

Loading...
View Options

src/qt/optionsdialog.cpp

Loading...