Page MenuHomePhabricator
Differential D3241

Merge #13877: utils: Make fs::path::string() always return utf-8 string on Windows
ClosedPublic
Actions

Authored by jasonbcox on Jun 6 2019, 22:49.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING9581a13b2008: Merge #13877: utils: Make fs::path::string() always return utf-8 string on…
rABC9581a13b2008: Merge #13877: utils: Make fs::path::string() always return utf-8 string on…
Summary

2c3eade704 Make fs::path::string() always return utf-8 string (Chun Kuan Lee)

Pull request description:

Imbue `fs::path` with `std::codecvt_utf8_utf16` at `SetupEnvironment()`, so that default string encoding will be utf-8 inside `fs::path`.

Tree-SHA512: 0cb59464d777278decbf24771fc5ff0cb2caa7bc2fe8ee5cd36c97a2324873a3caad131f08f050393b488316ee7f4ab0b28b7fa4699e41839f8e51b9867d5118

Backport of Core PR13877
https://github.com/bitcoin/bitcoin/pull/13877/files

Test Plan
make check
bitcoin-qt # sanity checks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13877
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6195
Build 10437: Bitcoin ABC Buildbot (legacy)
Build 10436: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 6 2019, 22:49
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 6 2019, 22:49
teamcity added a comment.Jun 6 2019, 22:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added inline comments.Jun 6 2019, 22:52
src/qt/guiutil.cpp
67

This backport is a bit out of order, so these lines do not appear in the original PR. They are not related however, so it should be ok.

teamcity added a comment.Jun 6 2019, 23:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6195: Diff 9218.Jun 6 2019, 23:00
jasonbcox added a child revision: D3242: Cleanup remaining boost includes.Jun 6 2019, 23:02
Fabien accepted this revision.Jun 7 2019, 09:24
This revision is now accepted and ready to land.Jun 7 2019, 09:24
Closed by commit rABC9581a13b2008: Merge #13877: utils: Make fs::path::string() always return utf-8 string on… (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJun 7 2019, 17:20
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC9581a13b2008: Merge #13877: utils: Make fs::path::string() always return utf-8 string on….
Fabien mentioned this in D3272: utils: run commands using utf-8 string on Windows.Jun 9 2019, 06:43
Fabien mentioned this in rABC897e59d0af84: utils: run commands using utf-8 string on Windows.Jun 9 2019, 15:37
jasonbcox added a commit: rSTAGING9581a13b2008: Merge #13877: utils: Make fs::path::string() always return utf-8 string on….Sep 19 2019, 00:08
Fabien mentioned this in rSTAGING897e59d0af84: utils: run commands using utf-8 string on Windows.Sep 19 2019, 00:10

Revision Contents
Changeset List

PathSize
src/
1 line
qt/
7 lines
4 lines

Diff 9218

View Options

src/fs.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/util.cpp

Loading...