Page MenuHomePhabricator
Differential D3261

Merge #10568: Remove unnecessary forward class declarations in header files
ClosedPublic
Actions

Authored by nakihito on Jun 7 2019, 21:11.

Details

Reviewers
jasonbcox
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING56d39e7dca49: Merge #10568: Remove unnecessary forward class declarations in header files
rABC56d39e7dca49: Merge #10568: Remove unnecessary forward class declarations in header files
Summary

4087d9ea7 Remove unnecessary forward class declarations in header files (practicalswift)

Tree-SHA512: 80a9b2cd339ba9c606c0dd93739ac80941b6050388fee2edd7976ae8b5e332fd0b4f1df1e89c1d6d28a77c23a36b1e874e72977985fb8f710c65c45c3a926f97

Backport of Core PR10568
https://github.com/bitcoin/bitcoin/pull/10568/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 7 2019, 21:11
Owners added a reviewer: Restricted Owners Package.Jun 7 2019, 21:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 21:11
teamcity added a comment.Jun 7 2019, 21:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 7 2019, 21:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6218: Diff 9251.Jun 7 2019, 21:21
markblundeberg accepted this revision.Jun 7 2019, 21:46
This revision is now accepted and ready to land.Jun 7 2019, 21:46
Closed by commit rABC56d39e7dca49: Merge #10568: Remove unnecessary forward class declarations in header files (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyJun 8 2019, 00:04
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC56d39e7dca49: Merge #10568: Remove unnecessary forward class declarations in header files.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING56d39e7dca49: Merge #10568: Remove unnecessary forward class declarations in header files.Sep 19 2019, 00:09

Revision Contents
Changeset List

Diff 9252

View Options

src/httprpc.h

Loading...
View Options

src/miner.h

Loading...
View Options

src/qt/addressbookpage.h

Loading...
View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/clientmodel.h

Loading...
View Options

src/qt/coincontroldialog.h

Loading...
View Options

src/qt/receivecoinsdialog.h

Loading...
View Options

src/qt/sendcoinsdialog.h

Loading...
View Options

src/qt/utilitydialog.h

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/ui_interface.h

Loading...
View Options

src/validation.h

Loading...
View Options

src/wallet/crypter.h

Loading...