Page MenuHomePhabricator
Differential D3288

[LINTER] Move phpcs ruleset to a test/lint/phpcs directory
ClosedPublic
Actions

Authored by Fabien on Jun 11 2019, 14:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING87fc03d54257: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory
rABC87fc03d54257: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory
Summary

Having the ruleset file located near the arcanist sources is not ideal.
Moving it to its own directory under test/lint/phpcs makes more sense.

Depends on D3287

Test Plan
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_phpcs_ruleset_move
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6279
Build 10605: Bitcoin ABC Buildbot (legacy)
Build 10604: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 11 2019, 14:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2019, 14:01
Herald added a reviewer: deadalnix. · View Herald Transcript
Harbormaster failed remote builds in B6264: Diff 9312!Jun 11 2019, 14:01
teamcity added a comment.Jun 11 2019, 14:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 11 2019, 14:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6264: Diff 9312.Jun 11 2019, 14:09
Fabien updated this revision to Diff 9313.Jun 11 2019, 14:11

Add missing .arclint update

teamcity added a comment.Jun 11 2019, 14:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 11 2019, 14:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6265: Diff 9313.Jun 11 2019, 14:18
deadalnix accepted this revision.Jun 11 2019, 23:46
This revision is now accepted and ready to land.Jun 11 2019, 23:46
deadalnix added inline comments.Jun 11 2019, 23:47
.arclint
55 ↗(On Diff #9313)

Give that file a proper name.

Fabien updated this revision to Diff 9340.Jun 12 2019, 08:49

Rename the ruleset file phpcs_ruleset => bitcoinabc_ruleset

teamcity added a comment.Jun 12 2019, 08:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 12 2019, 08:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6279: Diff 9340.Jun 12 2019, 08:56
Closed by commit rABC87fc03d54257: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory (authored by Fabien). · Explain WhyJun 12 2019, 10:32
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC87fc03d54257: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.
jasonbcox mentioned this in D3710: Move PHPCS config file where it is used.Jul 22 2019, 21:12
Fabien added a commit: rSTAGING87fc03d54257: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.Sep 19 2019, 00:13

Revision Contents
Changeset List

PathSize
2 lines
arcanist/
linter/
test/
lint/
phpcs/
arcanist/
linter/
bitcoinabc_ruleset.xml
phpcs_ruleset.xml
51 lines

Diff 9340

View Options

.arclint

Loading...
View Options

arcanist/linter/phpcs_ruleset.xml

Loading...
View Options

test/lint/phpcs/bitcoinabc_ruleset.xml

Loading...