Page MenuHomePhabricator
Differential D3301

Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it
ClosedPublic
Actions

Authored by deadalnix on Jun 12 2019, 12:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING167773c1432d: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it
rABC167773c1432d: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it
Summary

Allows SelectCoinsMinConf and SelectCoins be able to switch between
using BnB or Knapsack for choosing coins.

Has SelectCoinsMinConf do the preprocessing necessary to support either
BnB or Knapsack. This includes calculating the filtering the effective
values for each input.

Uses BnB in CreateTransaction to find an exact match for the output.
If BnB fails, it will fallback to the Knapsack solver.

This is a parital backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/6a34ff5335786615771ca423134a484b04831c4e

Depends on D3297, D3296, D3291, D3251, D3243 and D3290

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
selectcoinminconf
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6283
Build 10613: Bitcoin ABC Buildbot (legacy)
Build 10612: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 12 2019, 12:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2019, 12:48
teamcity added a comment.Jun 12 2019, 12:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Jun 12 2019, 12:49
deadalnix edited the summary of this revision. (Show Details)
deadalnix edited the summary of this revision. (Show Details)
deadalnix added parent revisions: D3290: Move original knapsack solver tests to coinselector_tests.cpp, D3243: Calculate and store the number of bytes required to spend an input.
Harbormaster completed remote builds in B6283: Diff 9348.Jun 12 2019, 12:56
teamcity added a comment.Jun 12 2019, 12:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D3304: Add a test to make sure that negative effective values are filtered.Jun 12 2019, 16:12
deadalnix updated this revision to Diff 9391.Jun 13 2019, 13:15

rebase

teamcity added a comment.Jun 13 2019, 13:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 13 2019, 13:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6305: Diff 9391.Jun 13 2019, 13:23
Fabien requested changes to this revision.Jun 17 2019, 09:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
3023 ↗(On Diff #9391)

The witness overhead should not be accounted

This revision now requires changes to proceed.Jun 17 2019, 09:35
deadalnix updated this revision to Diff 9495.Jun 17 2019, 16:27

Remove witness overhead

teamcity added a comment.Jun 17 2019, 16:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 17 2019, 16:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6379: Diff 9495.Jun 17 2019, 16:34
Fabien accepted this revision.Jun 18 2019, 06:05
This revision is now accepted and ready to land.Jun 18 2019, 06:05
Closed by commit rABC167773c1432d: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 18 2019, 12:18
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC167773c1432d: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
deadalnix added a commit: rSTAGING167773c1432d: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.Sep 19 2019, 00:23

Revision Contents
Changeset List

PathSize
src/
bench/
12 lines
wallet/
test/
179 lines
24 lines
160 lines

Diff 9348

View Options

src/bench/coin_selection.cpp

Loading...
View Options

src/wallet/test/coinselector_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...